dgfirmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
1:53 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -8
    • +10
    ./ROPump.c
  2. … 4 more files in changeset.
1:51 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:49 pm

Michael Garthwaite

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212 The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBAC...

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212

The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBACK_DUTY_CYCLE register on the FPGA in execROPumpMonitor/

No issue renaming it but is it a voltage or a duty cycle?

1:29 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:29 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:28 pm

Sean Nash

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

1:23 pm

Sean Nash

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

1:21 pm

Sean Nash

Add another blank line here (separates normal code from test code).

Add another blank line here (separates normal code from test code).

1:17 pm

Sean Nash

Put parenthesis around inner conditions. Put constant on left side of "==".

Put parenthesis around inner conditions. Put constant on left side of "==".

1:14 pm

Sean Nash

Voltage mis-spelled. Should rename anyway per comment above.

Voltage mis-spelled. Should rename anyway per comment above.

1:13 pm

Sean Nash

Variable suggests this is a duty cycle (not a voltage). Suggest renaming function.

Variable suggests this is a duty cycle (not a voltage). Suggest renaming function.

1:09 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:58 am

wbracken  (deleted user)

Update header. systemREG1 input and output.

Update header. systemREG1 input and output.

10:56 am

wbracken  (deleted user)

Update header.

Update header.

10:56 am

wbracken  (deleted user)

Update header.

Update header.

10:55 am

wbracken  (deleted user)

Update header.

Update header.

10:53 am

wbracken  (deleted user)

Where is inactiveRsrv declared.

Where is inactiveRsrv declared.

10:50 am

wbracken  (deleted user)

Should be using variable names? or is description OK?

Should be using variable names? or is description OK?

10:49 am

wbracken  (deleted user)

Remove blank lines

Remove blank lines

10:48 am

wbracken  (deleted user)

Input is integratedVolumeML

Input is integratedVolumeML

10:41 am

wbracken  (deleted user)

Alignment.

Alignment.

10:41 am

wbracken  (deleted user)

Update header. Looks like header may have been incorrect before changes.

Update header. Looks like header may have been incorrect before changes.

10:37 am

wbracken  (deleted user)

Update header.

Update header.

Friday 18 Nov 2022
4:49 pm

Dara Navaei

2:18 pm

jtaylor  (deleted user)

Is this a placeholder? Should have a "TODO" comment for the planned updates. Are the flow profiles intended to change eventually? Do some of these states have different pump load conditions? Test/t...

Is this a placeholder? Should have a "TODO" comment for the planned updates. Are the flow profiles intended to change eventually? Do some of these states have different pump load conditions? Test/tuning plans? Where will setROPIFlowProfile() be called? etc.

1:48 pm

Michael Garthwaite

Merge branch 'DEN-14197-sw-s83-mg-pi-optimizations' into develop

Options
    • -11
    • +12
    ./ROPump.c
1:48 pm

Michael Garthwaite

DEN-14197: Created a set pwm step limit for PI controllers. Updated RO pump profiles to contain a max set step limit. Removed unused #defines for ro pump.

Options
    • -11
    • +12
    ./ROPump.c
  2. … 2 more files in changeset.
1:48 pm

Michael Garthwaite

DEN-14197: Created a set pwm step limit for PI controllers. Updated RO pump profiles to contain a max set step limit. Removed unused defines for ro pump.

Options
    • -11
    • +12
    ./ROPump.c
  2. … 2 more files in changeset.
Thursday 17 Nov 2022
4:41 pm

Dara Navaei

Merged DEN-14307

Options
    • -0
    • +1
    ./ROPump.c
  2. … 1 more file in changeset.
4:38 pm

Dara Navaei

DEN-14307 updated the code and updated the checkAlarms.sh to check the alarms manual table upon compilation

Options
    • -2
    • +2
    ./ROPump.c
  2. … 5 more files in changeset.