Activity dgfirmware/firmware/App/Controllers

3:43 pm

Dara Navaei

More
2b60564
changed 30 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more DG-DEN-14902-1 DG-DEN-15336-1

Merged staging and resolved merge conflicts

- -6
- +6
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -18
- +17
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -0
- +16
./Fans.h
- History
- Source
- Diff
./Fans.h
- -12
- +11
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -7
- +8
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -24
- +44
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -1
- +18
./Switches.c
- History
- Source
- Diff
./Switches.c
- -7
- +8
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -1
- +19
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c
… 21 more files in changeset.

1:59 pm

Hung Nguyen <hnguyen@diality.com>

More
0a6fec6
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906 Added dialysate flow rate out of range alarm

- -0
- +6
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c

11:23 am

Dara Navaei

More
DG-DEN-9480-1
Closed

11:05 am

Dara Navaei

More
103d68b
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 1 more file in changeset.

11:04 am

Dara Navaei

More
2502d72
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more

Merge branch 'staging' of ssh://dvm-linux02:7999/dg/dgfirmware into staging

- -6
- +6
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 1 more file in changeset.

11:04 am

Dara Navaei

More
dfc8cf4
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-UCOMMITS-38

Removed the DEBUG_DENALI comment

- -2
- +0
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 1 more file in changeset.

10:57 am

Dara Navaei

More
94a1905
changed 93 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1 DG-UCOMMITS-37

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -6
- +6
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -6
- +6
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -6
- +6
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -6
- +6
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h
- -6
- +6
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -6
- +6
./DrainPump.h
- History
- Source
- Diff
./DrainPump.h
- -0
- +16
./Fans.c
- History
- Source
- Diff
./Fans.c
- -0
- +16
./Fans.h
- History
- Source
- Diff
./Fans.h
- -5
- +5
./FluidLeak.c
- History
- Source
- Diff
./FluidLeak.c
- -5
- +5
./FluidLeak.h
- History
- Source
- Diff
./FluidLeak.h
- -6
- +6
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -6
- +6
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -6
- +6
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -6
- +6
./LoadCell.h
- History
- Source
- Diff
./LoadCell.h
- -6
- +6
./Pressures.c
- History
- Source
- Diff
./Pressures.c
… 78 more files in changeset.

10:54 am

hnguyen (deleted user) and Sean Nash

More
DG-DEN-9480-1
finished reviewing

10:51 am

Dara Navaei

More
ddd2e12
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 207 more DG-DEN-9480-1

DEN-9480 updated documentation

- -1
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +1
./Valves.c
- History
- Source
- Diff
./Valves.c
… 1 more file in changeset.

10:37 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:35 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

9:08 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:07 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

9:05 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:04 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

5:37 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

3:38 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

3:07 pm

Dara Navaei

More
ce20c15
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906 added self test for the dialysate flow sensor and removed its broadcast function

- -2
- +29
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c
- -0
- +2
./DialysateFlow.h
- History
- Source
- Diff
./DialysateFlow.h
… 3 more files in changeset.

2:35 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

2:29 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

2:14 pm

Hung Nguyen <hnguyen@diality.com>

More
4130366
changed 3 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged dialysate flow sensor calibration

- -14
- +33
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c
… 2 more files in changeset.

12:55 pm

Hung Nguyen <hnguyen@diality.com>

More
66c7171
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more DG-DEN-9906-1

DEN-9906 Removed code added to collect unfiltered dialysate flow data

- -3
- +1
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c

11:17 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:15 am

Sean Nash

More
Re: DG-DEN-9906-1
commented on review

Need to range check flow.

11:10 am

Sean Nash

More
Re: DG-DEN-9906-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

11:09 am

hnguyen (deleted user)

More
Re: DG-DEN-9906-1
replied to Sean Nash

I removed the alarm.

11:09 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to Sean Nash

Done.

Controllers

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

hnguyen (deleted user) and Sean Nash

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

Hung Nguyen <hnguyen@diality.com>

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Sean Nash

hnguyen (deleted user)

Dara Navaei