dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Feb 2022
4:31 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated conductivity

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -11
    • +11
    ./TemperatureSensors.c
3:29 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated conductivity test

Options
    • -11
    • +23
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
3:00 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature out of range test

Options
    • -3
    • +6
    ./TemperatureSensors.c
  2. … 1 more file in changeset.
2:08 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature, rejection ratio, CPo with new values

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -6
    • +26
    ./TemperatureSensors.c
  3. … 1 more file in changeset.
12:47 pm

Dara Navaei

DEN-12225 updated the UV reactors

Options
    • -1
    • +2
    ./UVReactors.c
10:52 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -1
    • +1
    ./ConcentratePumps.c
    • -1
    • +1
    ./Heaters.c
    • -7
    • +11
    ./ROPump.c
  4. … 1 more file in changeset.
10:39 am

Dara Navaei

DEN-11750 updated the code

Options
    • -1
    • +1
    ./Fans.c
    • -1
    • +1
    ./Heaters.c
    • -7
    • +11
    ./ROPump.c
    • -1
    • +2
    ./ROPump.h
  5. … 2 more files in changeset.
10:14 am

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Implemented conductivity updates

Options
    • -1
    • +1
    ./ConcentratePumps.h
    • -9
    • +4
    ./ConductivitySensors.h
  3. … 1 more file in changeset.
Tuesday 22 Feb 2022
5:16 pm

Michael Garthwaite

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

We should probably keep the = 0;

We should probably keep the = 0;

5:02 pm

Sean Nash

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
    • -0
    • +2
    ./ConcentratePumps.c
5:02 pm

Sean Nash

DEN-11750: Fixed casting error in ConcentratePumps.c.

Options
    • -1
    • +1
    ./ConcentratePumps.c
4:18 pm

Dara Navaei

Merged DEN-11750 and resolved the coflicts

Options
    • -0
    • +2
    ./ConcentratePumps.c
    • -3
    • +3
    ./ConductivitySensors.c
    • -106
    • +11
    ./Heaters.c
    • -22
    • +11
    ./ROPump.c
    • -3
    • +2
    ./Switches.c
  6. … 3 more files in changeset.
4:01 pm

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:48 pm

Dara Navaei

DEN-11750 addressed the bugs that Code Clinic reported

Options
    • -5
    • +4
    ./Fans.c
    • -1
    • +1
    ./Fans.h
    • -1
    • +1
    ./Heaters.c
    • -3
    • +2
    ./Switches.c
  5. … 3 more files in changeset.
3:47 pm

Dara Navaei

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
12:57 pm

Dara Navaei

DEN-11750 added more comments

Options
    • -15
    • +8
    ./ROPump.c
10:59 am

Dara Navaei

DEN-11750 worked on the RO pump duty cycle feedback

Options
    • -0
    • +2
    ./ConcentratePumps.c
    • -105
    • +10
    ./Heaters.c
    • -13
    • +9
    ./ROPump.c
  4. … 2 more files in changeset.
Sunday 20 Feb 2022
5:37 pm

Dara Navaei

DEM-11750 updated the code

Options
    • -1
    • +1
    ./Heaters.c
  2. … 1 more file in changeset.
Monday 14 Feb 2022
11:07 am

Sean Nash

DEN-11750: Fixed drain pump RPM out of range alarm.

Options
    • -4
    • +6
    ./DrainPump.c
10:17 am

Dara Navaei

DEN-11750 updated the drain pump

Options
    • -1
    • +1
    ./DrainPump.c
  2. … 1 more file in changeset.
Wednesday 09 Feb 2022
5:32 pm

Hung Nguyen <hnguyen@diality.com>

Updated code to store the raw conductivity data from sensors CD1 and CD2

Options
    • -1
    • +4
    ./ConductivitySensors.c
3:56 pm

Dara Navaei

DEN-11750 updated the drain pump RPM to make sure the pump's RPM is only checked if the pumpis running

Options
    • -13
    • +13
    ./DrainPump.c
1:04 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11250 Updated conductivity sensors manufacture information

Options
    • -1
    • +15
    ./ConductivitySensors.h
12:29 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data. Updated FW code per peer review comments

Options
    • -90
    • +9
    ./ConductivitySensors.c
Tuesday 08 Feb 2022
9:02 pm

Dara Navaei

DEN-11750 enabled the load cells tare alarm

Options
    • -1
    • +1
    ./LoadCell.c
5:31 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data

Options
    • -1
    • +91
    ./ConductivitySensors.c
    • -0
    • +8
    ./ConductivitySensors.h