dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Feb 2022
6:03 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated deliver dialysate state

Options
    • -0
    • +5
    ./ConductivitySensors.h
  2. … 1 more file in changeset.
3:36 pm

Michael Garthwaite

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

3:33 pm

Michael Garthwaite

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Do we need an if for an always true condition? does this branch statement need to be uncommented?

3:25 pm

Michael Garthwaite

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

3:17 pm

Michael Garthwaite

I think this alarm should be not commented out.

I think this alarm should be not commented out.

11:29 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -3
    • +4
    ./ConcentratePumps.c
    • -6
    • +6
    ./ROPump.c
11:28 am

Dara Navaei

DEN-11750 updated the concentrate pumps

Options
    • -3
    • +4
    ./ConcentratePumps.c
    • -6
    • +6
    ./ROPump.c
  3. … 1 more file in changeset.
Wednesday 23 Feb 2022
8:28 pm

Dara Navaei

Merge branch 'DEN-11928-dg-conductivity-update-den-tbd' into develop

Options
    • -11
    • +23
    ./ConductivitySensors.c
    • -9
    • +4
    ./ConductivitySensors.h
    • -6
    • +29
    ./TemperatureSensors.c
  4. … 1 more file in changeset.
8:19 pm

Dara Navaei

DEN-12225, DEN-12221 added code to update the UV reactors health and to calculate the target flow change based on the target drain pump RPM

Options
    • -3
    • +12
    ./UVReactors.c
  2. … 1 more file in changeset.
4:31 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated conductivity

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -11
    • +11
    ./TemperatureSensors.c
3:29 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated conductivity test

Options
    • -11
    • +23
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
3:00 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature out of range test

Options
    • -3
    • +6
    ./TemperatureSensors.c
  2. … 1 more file in changeset.
2:08 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature, rejection ratio, CPo with new values

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -6
    • +26
    ./TemperatureSensors.c
  3. … 1 more file in changeset.
12:47 pm

Dara Navaei

DEN-12225 updated the UV reactors

Options
    • -1
    • +2
    ./UVReactors.c
10:52 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -1
    • +1
    ./ConcentratePumps.c
    • -1
    • +1
    ./Heaters.c
    • -7
    • +11
    ./ROPump.c
  4. … 1 more file in changeset.
10:39 am

Dara Navaei

DEN-11750 updated the code

Options
    • -1
    • +1
    ./Fans.c
    • -1
    • +1
    ./Heaters.c
    • -7
    • +11
    ./ROPump.c
    • -1
    • +2
    ./ROPump.h
  5. … 2 more files in changeset.
10:14 am

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Implemented conductivity updates

Options
    • -1
    • +1
    ./ConcentratePumps.h
    • -9
    • +4
    ./ConductivitySensors.h
  3. … 1 more file in changeset.
Tuesday 22 Feb 2022
5:16 pm

Michael Garthwaite

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

We should probably keep the = 0;

We should probably keep the = 0;

5:02 pm

Sean Nash

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
    • -0
    • +2
    ./ConcentratePumps.c
5:02 pm

Sean Nash

DEN-11750: Fixed casting error in ConcentratePumps.c.

Options
    • -1
    • +1
    ./ConcentratePumps.c
4:18 pm

Dara Navaei

Merged DEN-11750 and resolved the coflicts

Options
    • -0
    • +2
    ./ConcentratePumps.c
    • -3
    • +3
    ./ConductivitySensors.c
    • -106
    • +11
    ./Heaters.c
    • -22
    • +11
    ./ROPump.c
    • -3
    • +2
    ./Switches.c
  6. … 3 more files in changeset.
4:01 pm

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:48 pm

Dara Navaei

DEN-11750 addressed the bugs that Code Clinic reported

Options
    • -5
    • +4
    ./Fans.c
    • -1
    • +1
    ./Fans.h
    • -1
    • +1
    ./Heaters.c
    • -3
    • +2
    ./Switches.c
  5. … 3 more files in changeset.
3:47 pm

Dara Navaei

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
12:57 pm

Dara Navaei

DEN-11750 added more comments

Options
    • -15
    • +8
    ./ROPump.c
10:59 am

Dara Navaei

DEN-11750 worked on the RO pump duty cycle feedback

Options
    • -0
    • +2
    ./ConcentratePumps.c
    • -105
    • +10
    ./Heaters.c
    • -13
    • +9
    ./ROPump.c
  4. … 2 more files in changeset.