Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11928 Removed blank lines

  1. … 1 more file in changeset.
Looks like this needs to be addressed.

Looks like this needs to be addressed.

DEN-11928 Removed 5 secs persistent conductivity test SRSDG 558 & SRSDG 630

  1. … 1 more file in changeset.
Magic #.

Magic #.

rpm should be in ().

rpm should be in ().

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

There are 2 functions in this module with this name.

There are 2 functions in this module with this name.

Are these really common? Can they be moved to sys_selftest.c?

Are these really common? Can they be moved to sys_selftest.c?

DG-DEN-11928_DG Conductivity Update
DG-DEN-11928_DG Conductivity Update
Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this enum.

Add #ifndef RELEASE around this enum.

Should be #ifndef RELEASE around this structure.

Should be #ifndef RELEASE around this structure.

I think there should be a #ifndef RELEASE around these build switches.

I think there should be a #ifndef RELEASE around these build switches.

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

DEN-11928 Updated deliver dialysate state

  1. … 1 more file in changeset.
Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

I think this alarm should be not commented out.

I think this alarm should be not commented out.

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

DEN-11750 updated the concentrate pumps

  1. … 1 more file in changeset.
Merge branch 'DEN-11928-dg-conductivity-update-den-tbd' into develop

  1. … 1 more file in changeset.
DEN-12225, DEN-12221 added code to update the UV reactors health and to calculate the target flow change based on the target drain pump RPM

  1. … 1 more file in changeset.
DEN-11928 Updated conductivity

DEN-11928 Updated conductivity test

  1. … 1 more file in changeset.
DEN-11928 Updated temperature out of range test

  1. … 1 more file in changeset.
DEN-11928 Updated temperature, rejection ratio, CPo with new values

  1. … 1 more file in changeset.
DEN-12225 updated the UV reactors

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

  1. … 1 more file in changeset.