Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Looks like this needs to be addressed.

Looks like this needs to be addressed.

Magic #.

Magic #.

rpm should be in ().

rpm should be in ().

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

There are 2 functions in this module with this name.

There are 2 functions in this module with this name.

Are these really common? Can they be moved to sys_selftest.c?

Are these really common? Can they be moved to sys_selftest.c?

DG-DEN-11928_DG Conductivity Update
DG-DEN-11928_DG Conductivity Update
Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this enum.

Add #ifndef RELEASE around this enum.

Should be #ifndef RELEASE around this structure.

Should be #ifndef RELEASE around this structure.

I think there should be a #ifndef RELEASE around these build switches.

I think there should be a #ifndef RELEASE around these build switches.

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

I think this alarm should be not commented out.

I think this alarm should be not commented out.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

We should probably keep the = 0;

We should probably keep the = 0;

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.