Activity dgfirmware/firmware/App/Controllers

9:04 pm

Dara Navaei

More
851ee57
changed 8 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more DG-DEN-13834-1

DEN-13834 removed all the traces of DialysateFlow driver

- -290
- +0
./DialysateFlow.c
- History
- Source
- Diff
./DialysateFlow.c
- -61
- +0
./DialysateFlow.h
- History
- Source
- Diff
./DialysateFlow.h
- -5
- +5
./FlowSensors.c
- History
- Source
- Diff
./FlowSensors.c
- -8
- +0
./FlowSensors.h
- History
- Source
- Diff
./FlowSensors.h
- -15
- +1
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 3 more files in changeset.

3:08 pm

Dara Navaei

More
8074ece
changed 14 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more DG-DEN-13834-1

DEN-13834, DEN-13691, DEN-13685, DEN-13064, DEN-9693, DEN-13778, Updated the flow sensors driver by fixing the override functions. Removed the old RO flow functions and anywhere that they were used. Replaced the VRD valve with a reserved space

- -0
- +15
./FlowSensors.c
- History
- Source
- Diff
./FlowSensors.c
- -1
- +2
./FlowSensors.h
- History
- Source
- Diff
./FlowSensors.h
- -4
- +10
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -129
- +6
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -6
- +0
./ROPump.h
- History
- Source
- Diff
./ROPump.h
- -2
- +3
./UVReactors.c
- History
- Source
- Diff
./UVReactors.c
- -5
- +29
./Valves.c
- History
- Source
- Diff
./Valves.c
- -2
- +3
./Valves.h
- History
- Source
- Diff
./Valves.h
… 6 more files in changeset.

3:09 pm

Dong Nguyen <dnguyen@diality.com>

More
f8b2a4f
changed 5 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 188 more DG-DEN-13598-2

DEN-13598: Add code for RAM error and FPGA clcok speed.

- -0
- +3
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -0
- +3
./LoadCell.h
- History
- Source
- Diff
./LoadCell.h
- -0
- +4
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -0
- +3
./TemperatureSensors.h
- History
- Source
- Diff
./TemperatureSensors.h
… 1 more file in changeset.

3:09 pm

Dong Nguyen <dnguyen@diality.com>

More
66137c8
changed 8 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 188 more DG-DEN-13598-2

DEN-13598: Add code for RAM error and FPGA clcok speed.

- -14
- +0
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -10
- +0
./LoadCell.h
- History
- Source
- Diff
./LoadCell.h
- -7
- +0
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -29
- +0
./TemperatureSensors.h
- History
- Source
- Diff
./TemperatureSensors.h
… 4 more files in changeset.

11:08 am

Sean Nash

More
Re: DG-DEN-13460-2
replied to dcox (deleted user)

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

10:31 am

Sean Nash

More
Re: DG-DEN-13460-2
commented on review

Remove blank line.

9:52 am

Dong Nguyen <dnguyen@diality.com>

More
a26a945
changed 7 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 188 more DG-DEN-13598-2

DEN-13598 updated the code

- -15
- +0
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -11
- +0
./LoadCell.h
- History
- Source
- Diff
./LoadCell.h
- -6
- +0
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -30
- +0
./TemperatureSensors.h
- History
- Source
- Diff
./TemperatureSensors.h
… 3 more files in changeset.

8:36 pm

Dara Navaei

More
cb4d35c
changed 16 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 187 more DG-DEN-13834-1

DEN-13834 updated the getValveState function to return the state of the valve in enum. Updated the treatment blocking data to be written to NV data. Updated the FlowSensors driver and renamed the dialysate flow messages to flow sensors messages

- -16
- +15
./FlowSensors.c
- History
- Source
- Diff
./FlowSensors.c
- -7
- +14
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -3
- +3
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -13
- +48
./Valves.c
- History
- Source
- Diff
./Valves.c
- -28
- +27
./Valves.h
- History
- Source
- Diff
./Valves.h
… 11 more files in changeset.

4:24 pm

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:24 pm

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:23 pm

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:23 pm

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:04 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

4:03 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

3:46 pm

Michael Garthwaite

More
fc11115
changed 13 files
DEN-14902-bootloader-for-dg, develop DG-DEN-14902-1 DG-DEN-15336-1

Merge branch 'DEN-13801-sw_dev-sprint-79_mg' into develop

- -2
- +2
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -7
- +7
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -2
- +2
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -2
- +2
./TemperatureSensors.h
- History
- Source
- Diff
./TemperatureSensors.h
… 9 more files in changeset.

3:34 pm

Michael Garthwaite

More
DG-DEN-13427-1
Closed

3:34 pm

wbracken (deleted user)

More
DG-DEN-13427-1
finished reviewing

3:32 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTRHOUGH

12:21 pm

dcox (deleted user)

More
Re: DG-DEN-13460-2
commented on review

Use 0.0F

12:17 pm

dcox (deleted user)

More
Re: DG-DEN-13460-2
commented on review

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

2:07 pm

Dara Navaei

More
9aa6661
changed 2 files
DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle, DEN-13154-heparin-syringe-empty-position-incorrect and 189 more DG-DEN-13460-2

DEN-13460 added PiSquare VectorCAST

- -12
- +0
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 1 more file in changeset.

1:56 pm

Michael Garthwaite

More
Re: DG-DEN-13427-1
replied to wbracken (deleted user)

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

10:04 am