Activity dgfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 2

Total Committers:	16
Last Commit:	08 Jun
Commits this week:	2

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 16 Jan 2023

1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
fd3086e
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 Code review correction

- -1
- +0
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c

12:11 pm

wbracken (deleted user)

More
Re: DG-DEN-14559-1
commented on review

Alignment

Alignment

10:55 am

jtaylor (deleted user)

More
Re: DG-DEN-14559-1
commented on review

Alignment

Alignment

Sunday 15 Jan 2023

3:27 pm

Dara Navaei

More
fcaca09
changed 8 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 168 more DG-DEN-14559-1

DEN-14559 updated the cleaning modes with the SRS changes

- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
… 7 more files in changeset.

Friday 13 Jan 2023

11:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
d922241
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 Darren comments DEN-14075 Corrected thermistor override in previous commit

- -6
- +2
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c

11:39 am

wbracken (deleted user)

More
Re: DG-DEN-13946-1
replied to dcox (deleted user)

Corrected.

Corrected.

11:38 am

wbracken (deleted user)

More
Re: DG-DEN-13946-1
replied to dcox (deleted user)

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

11:31 am

wbracken (deleted user)

More
Re: DG-DEN-13946-1
replied to dcox (deleted user)

Only used if the load cell is out of range.

Only used if the load cell is out of range.

10:41 am

dcox (deleted user)

More
Re: DG-DEN-13946-1
commented on review

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

10:38 am

dcox (deleted user)

More
Re: DG-DEN-13946-1
commented on review

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

10:35 am

dcox (deleted user)

More
Re: DG-DEN-13946-1
commented on review

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

10:34 am

dcox (deleted user)

More
Re: DG-DEN-13946-1
commented on review

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

Thursday 12 Jan 2023

5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
1b0e869
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 Correction to thermistor timeout.

- -1
- +1
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c

5:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
e6f434d
changed 9 files
DEN-14902-bootloader-for-dg, develop DG-DEN-14902-1 DG-DEN-15336-1

Merge branch 'DEN-13946-certain-temperature-sensors-trigger-wrong-alarm' into develop

# Conflicts:

# firmware/App/DGCommon.h

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -1
- +1
./DrainPump.h
- History
- Source
- Diff
./DrainPump.h
- -6
- +6
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -14
- +16
./LoadCell.c
- History
- Source
- Diff
./LoadCell.c
- -2
- +2
./ROPump.h
- History
- Source
- Diff
./ROPump.h
… 4 more files in changeset.

4:56 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
71013d0
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 Complete and tested for termperatures, pressures, load cells and thermistors. DEN-14075 Corrected thermistor override limits.

- -30
- +42
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c

Wednesday 11 Jan 2023

6:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
b227905
changed 2 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

Merge branch 'staging' into DEN-13946-certain-temperature-sensors-trigger-wrong-alarm

- -11
- +21
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -6
- +17
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c

5:01 pm

Dara Navaei

More
DG-DEN-14559-1
started review

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8

4:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
b357773
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 Update thermistor init.

- -7
- +21
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c

2:13 pm

Dara Navaei

More
DG-DEN-14497-1
Closed

2:13 pm

Dara Navaei

More
b8f2985
changed 24 files
master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 172 more DG-DEN-13946-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -1
- +1
./ConductivitySensors.h
- History
- Source
- Diff
./ConductivitySensors.h
- -1
- +1
./DrainPump.c
- History
- Source
- Diff
./DrainPump.c
- -1
- +1
./DrainPump.h
- History
- Source
- Diff
./DrainPump.h
- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -1
- +1
./Heaters.h
- History
- Source
- Diff
./Heaters.h
- -1
- +1
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -1
- +1
./ROPump.c
- History
- Source
- Diff
./ROPump.c
- -2
- +2
./ROPump.h
- History
- Source
- Diff
./ROPump.h
- -1
- +1
./TemperatureSensors.c
- History
- Source
- Diff
./TemperatureSensors.c
- -1
- +1
./Voltages.h
- History
- Source
- Diff
./Voltages.h
… 13 more files in changeset.

1:22 pm

Sean Nash

More
DG-DEN-14497-1
finished reviewing

1:10 pm

wbracken (deleted user)

More
Re: DG-DEN-14497-1
replied to wbracken (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

1:02 pm

Dara Navaei

More
688e833
changed 1 file
master, DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle and 173 more DG-DEN-14497-1

DEN-14497 addressed the code review comment

- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c

11:47 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
87e007b
changed 3 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 169 more DG-DEN-13946-1

DEN-13946 - Alarm generation is complete. Thermistors now configured based upon beta or DVT hardware configurations. Working with Noe to address FPGA thermistor values after reset.

- -14
- +34
./Thermistors.c
- History
- Source
- Diff
./Thermistors.c
… 2 more files in changeset.

11:24 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:23 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:23 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:22 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:21 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:20 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-09 18:55 -0700