dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 2
Total Committers: 16
Last Commit: 08 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jan 2023
1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

Options
    • -4
    • +4
    ./ConcentratePumps.c
12:03 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:00 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:20 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Make monitor functions for pressure, temperature, thermistors and load cells consistent. Address code review comments.

Options
    • -24
    • +24
    ./LoadCell.c
    • -7
    • +7
    ./Pressures.c
    • -11
    • +11
    ./TemperatureSensors.c
    • -6
    • +7
    ./Thermistors.c
10:38 am

Dara Navaei

DEN-14559 added functions to reset the POST states of the drivers that have a POST state machine for the command to request POST again

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -0
    • +12
    ./Pressures.c
    • -1
    • +2
    ./Pressures.h
    • -2
    • +2
    ./TemperatureSensors.c
    • -3
    • +16
    ./UVReactors.c
    • -0
    • +2
    ./UVReactors.h
  7. … 7 more files in changeset.
Monday 16 Jan 2023
4:45 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Do not process thermistor alarms if in DG_INIT

Options
    • -1
    • +2
    ./Thermistors.c
3:01 pm

Dara Navaei

DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Code review correction

Options
    • -1
    • +0
    ./Thermistors.c
12:11 pm

wbracken  (deleted user)

Alignment

Alignment

10:55 am

jtaylor  (deleted user)

Alignment

Alignment

Sunday 15 Jan 2023
3:27 pm

Dara Navaei

DEN-14559 updated the cleaning modes with the SRS changes

Options
    • -1
    • +1
    ./TemperatureSensors.c
  2. … 7 more files in changeset.
Friday 13 Jan 2023
11:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Darren comments DEN-14075 Corrected thermistor override in previous commit

Options
    • -6
    • +2
    ./Thermistors.c
11:39 am

wbracken  (deleted user)

Corrected.

Corrected.

11:38 am

wbracken  (deleted user)

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

11:31 am

wbracken  (deleted user)

Only used if the load cell is out of range.

Only used if the load cell is out of range.

10:41 am

dcox  (deleted user)

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

10:38 am

dcox  (deleted user)

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

10:35 am

dcox  (deleted user)

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

10:34 am

dcox  (deleted user)

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

Thursday 12 Jan 2023
5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Correction to thermistor timeout.

Options
    • -1
    • +1
    ./Thermistors.c
5:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13946-certain-temperature-sensors-trigger-wrong-alarm' into develop

# Conflicts:

# firmware/App/DGCommon.h

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./DrainPump.h
    • -6
    • +6
    ./Heaters.c
    • -14
    • +16
    ./LoadCell.c
    • -2
    • +2
    ./ROPump.h
  6. … 4 more files in changeset.
4:56 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Complete and tested for termperatures, pressures, load cells and thermistors. DEN-14075 Corrected thermistor override limits.

Options
    • -30
    • +42
    ./Thermistors.c
Wednesday 11 Jan 2023
6:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13946-certain-temperature-sensors-trigger-wrong-alarm

Options
    • -11
    • +21
    ./Pressures.c
    • -6
    • +17
    ./TemperatureSensors.c
5:01 pm

Dara Navaei

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
4:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Update thermistor init.

Options
    • -7
    • +21
    ./Thermistors.c
2:13 pm

Dara Navaei

2:13 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./ConductivitySensors.h
    • -1
    • +1
    ./DrainPump.c
    • -1
    • +1
    ./DrainPump.h
    • -1
    • +1
    ./Heaters.c
    • -1
    • +1
    ./Heaters.h
    • -1
    • +1
    ./Pressures.c
    • -1
    • +1
    ./ROPump.c
    • -2
    • +2
    ./ROPump.h
    • -1
    • +1
    ./TemperatureSensors.c
    • -1
    • +1
    ./Voltages.h
  12. … 13 more files in changeset.
1:22 pm

Sean Nash

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

1:02 pm

Dara Navaei

DEN-14497 addressed the code review comment

Options
    • -1
    • +1
    ./Heaters.c