dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Mar 2023
2:34 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Heaters.c
  2. … 1 more file in changeset.
2:33 pm

Michael Garthwaite

2:32 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Thursday 02 Mar 2023
10:29 am

Michael Garthwaite

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

10:28 am

Michael Garthwaite

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

10:21 am

Sean Nash

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

10:19 am

Sean Nash

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

10:18 am

Sean Nash

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

10:13 am

Sean Nash

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:23 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 01 Mar 2023
2:49 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:49 pm

Michael Garthwaite

DEN-14788: code review comments

Options
    • -1
    • +1
    ./Heaters.c
2:33 pm

Dara Navaei

DEN-14834 updated the code to not check the rejection ratio and CPo if the target fill is less than 550 mL. Updated the heaters code to make sure the stop heaters command stops the heaters unless a new start command is issued

Options
    • -31
    • +39
    ./Heaters.c
  2. … 1 more file in changeset.
1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:00 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -1
    • +1
    ./LoadCell.c
  2. … 2 more files in changeset.
9:59 am

Michael Garthwaite

DEN-14689: message naming synchronization.

Options
    • -1
    • +1
    ./FluidLeak.c
    • -1
    • +1
    ./LoadCell.c
    • -1
    • +1
    ./Valves.c
  4. … 4 more files in changeset.
Monday 27 Feb 2023
3:12 pm

dcox  (deleted user)

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

3:09 pm

dcox  (deleted user)

Remove old function call.

Remove old function call.

11:09 am

Sean Nash

Add space between ( and TRUE.

Add space between ( and TRUE.

10:12 am

Sean Nash

I don't see DG changes using new ENUM names.

I don't see DG changes using new ENUM names.

9:56 am

Sean Nash

Remove "endif" at end of comment?

Remove "endif" at end of comment?

9:54 am

Sean Nash

What is this setting and why did it change?

What is this setting and why did it change?

8:50 am

jtaylor  (deleted user)

extra CR/LF deleted; two statements on one line.

extra CR/LF deleted; two statements on one line.

8:45 am

jtaylor  (deleted user)

Comment alignment (3x 147, 151, 157)

Comment alignment (3x 147, 151, 157)

Friday 24 Feb 2023
3:18 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Add buffer protection for emStat. Add NAK, CRC and timeout check for response to write actuators.

Options
    • -47
    • +5
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
1:42 pm

wbracken  (deleted user)

//* ?

//* ?