Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed. Thanks!

Fixed. Thanks!

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Remove old function call.

Remove old function call.

Add space between ( and TRUE.

Add space between ( and TRUE.

I don't see DG changes using new ENUM names.

I don't see DG changes using new ENUM names.

Remove "endif" at end of comment?

Remove "endif" at end of comment?

What is this setting and why did it change?

What is this setting and why did it change?

extra CR/LF deleted; two statements on one line.

extra CR/LF deleted; two statements on one line.

Comment alignment (3x 147, 151, 157)

Comment alignment (3x 147, 151, 157)

//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

Add function header.

Add function header.

Add function headers.

Add function headers.

Add tempBelowTargetStartTimeMS and rsrvrsStatus.

Add tempBelowTargetStartTimeMS and rsrvrsStatus.