dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 4
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Apr 2023
10:12 am

Dara Navaei

DEN-15182 added a pause state in standby mode for the inlet water conditions. Addressed the code review comments

Options
    • -45
    • +57
    ./DrainPump.c
    • -1
    • +1
    ./Thermistors.c
  3. … 3 more files in changeset.
10:05 am

Dara Navaei

Please check the code again.

Please check the code again.

8:37 am

Dara Navaei

Done

Done

8:35 am

Dara Navaei

Done

Done

8:34 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.

8:32 am

Dara Navaei

Done

Done

8:31 am

Sean Nash

request will remain if inlet alarms active. is that what we want?

request will remain if inlet alarms active. is that what we want?

8:31 am

Dara Navaei

Yes we do not support Beta in release.

Yes we do not support Beta in release.

8:28 am

Sean Nash

Looks like we will not read ADC channels at all if release build.

Looks like we will not read ADC channels at all if release build.

8:26 am

jtaylor  (deleted user)

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

8:26 am

Sean Nash

Needs default or just do if/else.

Needs default or just do if/else.

8:26 am

Sean Nash

Needs default or just do if/else.

Needs default or just do if/else.

8:24 am

Sean Nash

Yes, fault.

Yes, fault.

8:17 am

Sean Nash

Why remove?

Why remove?

Monday 17 Apr 2023
3:29 pm

wbracken  (deleted user) and Michael Garthwaite

12:51 pm

Dara Navaei

DEN-15166, DEN-15182 updated the voltages code and fixed the filter flush code to be able to resume after an inlet condition alarm

Options
    • -0
    • +1
    ./Voltages.c
  2. … 1 more file in changeset.
10:22 am

Dara Navaei

DEN-15166 uncommented the voltages alarm

Options
    • -2
    • +2
    ./Voltages.c
10:18 am

Dara Navaei

DEN-15166 added the Maxon drain pump RPM and the new non-isolated voltage

Options
    • -24
    • +76
    ./DrainPump.c
    • -7
    • +6
    ./DrainPump.h
    • -1
    • +3
    ./Thermistors.c
    • -3
    • +8
    ./Voltages.c
    • -0
    • +2
    ./Voltages.h
  6. … 5 more files in changeset.
8:39 am

jtaylor  (deleted user)

Sunday 16 Apr 2023
12:06 pm

Dara Navaei

12:04 pm

Dara Navaei

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
12:03 pm

Dara Navaei

Friday 14 Apr 2023
11:37 am

Sean Nash

Fixed merge conflicts from DEN-15105.

Options
    • -5
    • +4
    ./ConductivitySensors.c
  2. … 2 more files in changeset.
8:48 am

Dara Navaei

8:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConductivitySensors.c
    • -1
    • +1
    ./Pressures.c
    • -1
    • +1
    ./TemperatureSensors.c
  4. … 3 more files in changeset.
8:26 am

Sean Nash

8:21 am

Dara Navaei

DEN-15164 changed the inlet water conditions persistenet alarm to 30 seconds

Options
    • -4
    • +3
    ./ConductivitySensors.c
    • -1
    • +1
    ./Pressures.c
    • -1
    • +1
    ./TemperatureSensors.c
  4. … 2 more files in changeset.
Thursday 13 Apr 2023
12:01 pm

Dara Navaei

DG-DEN-15164_Inlet Water Temp Alarm Closes Vpi
DG-DEN-15164_Inlet Water Temp Alarm Closes Vpi
12:01 pm

Dara Navaei

DG-DEN-15166_Add Drain Pump Maxon Board RPM
DG-DEN-15166_Add Drain Pump Maxon Board RPM