Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off. The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize...

Yes. The pump minimum target is 3, attempting to set smaller than that limit results in the pump being turned off.

The underlying issue is that stepConcentratePumpToTargetSpeed does not initialize speedIncrease or hasTgtBeenReached, or update the currentPumpSpeed target unless the currentToTargetDiff is < nearly zero. Since the speeds are quantized, we'll see zero more frequently than expected. Particularly when stopping the pump, the Diff will be zero, and currentPumpSpeed may never be updated, leading to odd transient conditions.

By increasing the "zero" level, and adding the initialization and else clauses for zero error and stopping the pump, we guarantee that the speed setting is always set intentionally. Also we already have a minimum speed parameter, used to determine when to stop the motor, and attempts at motor control at these low levels.

DG-DEN-15462_Nelson Support With Alarm 77
DG-DEN-15462_Nelson Support With Alarm 77
DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
DG-DEN-15375_Dialysate Heating Fixes
DG-DEN-15375_Dialysate Heating Fixes
DG-DEN-15367_HD DG Test Configuration Setup
DG-DEN-15367_HD DG Test Configuration Setup
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Purpose is to account for cooling of dialysate from reservoir to dialyzer. The faster Qd is, the less cooling will occur (less time to cool). RESOLVED in CODE WALKTHROUGH.

Purpose is to account for cooling of dialysate from reservoir to dialyzer. The faster Qd is, the less cooling will occur (less time to cool).
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

If these are only for Dialin, move down to test support functions area.

If these are only for Dialin, move down to test support functions area.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Includes should be in alphabetical order.

Includes should be in alphabetical order.

Done

Done

Done

Done

Done

Done

Don't forget to roll compatibility for all 3 stacks.

Don't forget to roll compatibility for all 3 stacks.

function wants a U32. C will convert automatically, so not necessary I guess.

function wants a U32. C will convert automatically, so not necessary I guess.

Remove (U32) cast.

Remove (U32) cast.

Remove (U32) cast.

Remove (U32) cast.