dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Aug 2023
11:55 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

Options
    • -1
    • +5
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
11:51 am

James Walter Taylor <jtaylor@diality.com>

DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears

Incorporated HD mode check, to clear alarm 150/151

Options
    • -1
    • +5
    ./ConductivitySensors.c
10:59 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Change persistence to 12 seconds

Options
    • -1
    • +1
    ./ROPump.c
10:32 am

Vinayakam Mani

DEN-16093-merge in to develop

Options
    • -17
    • +17
    ./ConcentratePumps.c
  2. … 1 more file in changeset.
Tuesday 22 Aug 2023
11:57 am

Vinayakam Mani

DEN-16093-code alignment done

Options
    • -5
    • +5
    ./ConcentratePumps.c
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

Vinayakam Mani

DEN-16093-changes added in the park handler logic

Options
    • -17
    • +17
    ./ConcentratePumps.c
10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

9:14 am

Vinayakam Mani

DEN-16093 merge in to develop

Options
    • -0
    • +42
    ./ConcentratePumps.c
  2. … 3 more files in changeset.
Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

6:04 pm

Vinayakam Mani

DEN-16093 handler for DG park concnetrate pump added

Options
    • -0
    • +42
    ./ConcentratePumps.c
    • -0
    • +1
    ./ConcentratePumps.h
  3. … 2 more files in changeset.
4:05 pm

Dara Navaei

DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
2:31 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Change #define name

Options
    • -2
    • +2
    ./ROPump.c
1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

Friday 18 Aug 2023
1:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Correct #define name

Options
    • -3
    • +3
    ./ROPump.c
1:53 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13973 Rename alarm

Options
    • -1
    • +1
    ./ROPump.c
1:31 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Add RO Pump max PWM alarm

Options
    • -0
    • +11
    ./ROPump.c
Thursday 17 Aug 2023
6:05 pm

Dara Navaei

DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
2:04 pm

Dara Navaei

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
9:49 am

Dara Navaei

Merged DEN-16250

Options
    • -1
    • +1
    ./ConcentratePumps.c
  2. … 1 more file in changeset.
Wednesday 16 Aug 2023
5:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConcentratePumps.c
  2. … 5 more files in changeset.
5:31 pm

Dara Navaei

5:30 pm

wbracken  (deleted user) and Sean Nash

2:38 pm

Dara Navaei

2:04 pm

Dara Navaei

DG-DEN-15974_Alarm 187 Triggered During Consumables Check And During Treatment
DG-DEN-15974_Alarm 187 Triggered During Consumables Check And During Treatment
1:30 pm

Dara Navaei

Merged DEN-15964

Options
    • -2
    • +2
    ./ConcentratePumps.c
  2. … 4 more files in changeset.
1:27 pm

Dara Navaei

DEN-15974 removed the clearance time of the persistence alarms of the concentrate pumps

Options
    • -2
    • +2
    ./ConcentratePumps.c