Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met
DEN-16308 updated the DG watchdog and safety shutdown POSTs

  1. … 2 more files in changeset.
Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

Remove blank line.

Remove blank line.

Put declarations at top of function. Use our BOOL type. Put ternary in ().

Put declarations at top of function. Use our BOOL type. Put ternary in ().

No point to having non-zero clear persistence - it's a fault.

No point to having non-zero clear persistence - it's a fault.

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

  1. … 5 more files in changeset.
DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears

Incorporated HD mode check, to clear alarm 150/151

DEN-15973 Change persistence to 12 seconds

DEN-16093-merge in to develop

  1. … 1 more file in changeset.
DEN-16093-code alignment done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-16093-changes added in the park handler logic

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add a blank line between declarations and code.

Add a blank line between declarations and code.

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

DEN-16093 merge in to develop

  1. … 3 more files in changeset.
required changes are done.

required changes are done.

DEN-16093 handler for DG park concnetrate pump added

  1. … 2 more files in changeset.
DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
DG-DEN-16280_Stuck IN Post Treatment When Inlet Water Alarm Appears
DEN-15973 Change #define name

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

DEN-15973 Correct #define name

DEN-13973 Rename alarm

DEN-15973 Add RO Pump max PWM alarm

DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
Merged DEN-16250

  1. … 1 more file in changeset.