Activity dgfirmware/firmware/App/Controllers

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

More
Re: DG-DEN-16093-1
commented on review

100% now.

2:00 pm

Vinayakam Mani

More
f33973b
changed 4 files
develop

DEN-16093 fixed merging conflicts

- -4
- +5
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 3 more files in changeset.

12:42 pm

Sean Nash

More
Re: DG-DEN-16280-1
replied to jtaylor (deleted user)

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

12:05 pm

Dara Navaei

More
DG-DEN-16309-1
started review

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT

2:02 pm

jtaylor (deleted user)

More
Re: DG-DEN-16280-1
replied to Sean Nash

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely re...

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.

12:58 pm

Dara Navaei

More
48e631c
changed 5 files
master, DEN-14706-can-messge-not-acked-fix and 75 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +2
./Voltages.c
- History
- Source
- Diff
./Voltages.c
- -1
- +1
./Voltages.h
- History
- Source
- Diff
./Voltages.h
… 2 more files in changeset.

12:57 pm

Dara Navaei

More
DG-DEN-16308-1
Closed

12:46 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-16308-1
finished reviewing

11:27 am

Sean Nash

More
Re: DG-DEN-16280-1
commented on review

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature? FYI - getHDOperationMode()...

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature?

FYI - getHDOperationMode() was not working - HD op mode handler was mishandling message - fixed in my DENBUG-59 branch, but not yet in staging.

10:20 am

Dara Navaei

More
cfc93e9
changed 1 file
master, DEN-14706-can-messge-not-acked-fix and 75 more DG-DEN-16308-1

DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

- -3
- +4
./Heaters.c
- History
- Source
- Diff
./Heaters.c

9:58 am

Dara Navaei

More
DG-DEN-16308-1
started review

DG-DEN-16308_Srsdg 53 Not Met

9:50 am

Dara Navaei

More
31f5b77
changed 4 files
master, DEN-14706-can-messge-not-acked-fix and 75 more DG-DEN-16308-1

DEN-16308 updated the DG watchdog and safety shutdown POSTs

- -0
- +16
./Voltages.c
- History
- Source
- Diff
./Voltages.c
- -0
- +1
./Voltages.h
- History
- Source
- Diff
./Voltages.h
… 2 more files in changeset.

2:14 pm

Sean Nash

More
Re: DG-DEN-15973-1
commented on review

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

2:09 pm