dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 27 Aug 2023
3:51 pm

Dara Navaei

DEN-16309 removed the clearance period some of the persistence alarms

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -3
    • +3
    ./Heaters.c
    • -4
    • +4
    ./Pressures.c
Friday 25 Aug 2023
5:26 pm

wbracken  (deleted user)

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

Options
    • -1
    • +3
    ./ROPump.c
4:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Address code review comments

Options
    • -3
    • +1
    ./ROPump.c
4:37 pm

wbracken  (deleted user)

Corrected

Corrected

4:36 pm

wbracken  (deleted user)

Corrected

Corrected

4:36 pm

wbracken  (deleted user)

Corrected

Corrected

3:03 pm

Vinayakam Mani

Done.

Done.

3:03 pm

Vinayakam Mani

Done.

Done.

2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

2:00 pm

Vinayakam Mani

DEN-16093 fixed merging conflicts

Options
    • -4
    • +5
    ./Heaters.c
  2. … 3 more files in changeset.
12:42 pm

Sean Nash

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

12:05 pm

Dara Navaei

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
Thursday 24 Aug 2023
2:02 pm

jtaylor  (deleted user)

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely re...

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.

12:58 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Heaters.c
    • -2
    • +2
    ./Voltages.c
    • -1
    • +1
    ./Voltages.h
  4. … 2 more files in changeset.
12:57 pm

Dara Navaei

12:46 pm

wbracken  (deleted user) and Sean Nash

11:27 am

Sean Nash

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature? FYI - getHDOperationMode()...

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature?

FYI - getHDOperationMode() was not working - HD op mode handler was mishandling message - fixed in my DENBUG-59 branch, but not yet in staging.

10:20 am

Dara Navaei

DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

Options
    • -3
    • +4
    ./Heaters.c
9:58 am

Dara Navaei

DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met
9:50 am

Dara Navaei

DEN-16308 updated the DG watchdog and safety shutdown POSTs

Options
    • -0
    • +16
    ./Voltages.c
    • -0
    • +1
    ./Voltages.h
  3. … 2 more files in changeset.
Wednesday 23 Aug 2023
2:14 pm

Sean Nash

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:09 pm

Sean Nash

Put declarations at top of function. Use our BOOL type. Put ternary in ().

Put declarations at top of function. Use our BOOL type. Put ternary in ().

2:07 pm

Sean Nash

No point to having non-zero clear persistence - it's a fault.

No point to having non-zero clear persistence - it's a fault.

11:55 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

Options
    • -1
    • +5
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
11:51 am

James Walter Taylor <jtaylor@diality.com>

DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears

Incorporated HD mode check, to clear alarm 150/151

Options
    • -1
    • +5
    ./ConductivitySensors.c
10:59 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Change persistence to 12 seconds

Options
    • -1
    • +1
    ./ROPump.c
10:32 am

Vinayakam Mani

DEN-16093-merge in to develop

Options
    • -17
    • +17
    ./ConcentratePumps.c
  2. … 1 more file in changeset.