dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 29 Aug 2023
4:59 pm

Dara Navaei

Merged DEN-16309

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -10
    • +14
    ./Heaters.c
  3. … 2 more files in changeset.
2:07 pm

Dara Navaei

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
1:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

# Conflicts:

# firmware/App/DGCommon.h

Options
    • -4
    • +5
    ./Heaters.c
  2. … 2 more files in changeset.
1:25 pm

jtaylor  (deleted user)

12:39 pm

jtaylor  (deleted user)

9:03 am

jtaylor  (deleted user)

Monday 28 Aug 2023
2:25 pm

wbracken  (deleted user) and Sean Nash

10:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:08 am

Dara Navaei

9:08 am

Dara Navaei

8:43 am

Dara Navaei

DEN-16309 added a new heat disinfect state

Options
    • -7
    • +11
    ./Heaters.c
  2. … 2 more files in changeset.
Sunday 27 Aug 2023
3:51 pm

Dara Navaei

DEN-16309 removed the clearance period some of the persistence alarms

Options
    • -2
    • +2
    ./ConductivitySensors.c
    • -3
    • +3
    ./Heaters.c
    • -4
    • +4
    ./Pressures.c
Friday 25 Aug 2023
5:26 pm

wbracken  (deleted user)

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

Options
    • -1
    • +3
    ./ROPump.c
4:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15973 Address code review comments

Options
    • -3
    • +1
    ./ROPump.c
4:37 pm

wbracken  (deleted user)

Corrected

Corrected

4:36 pm

wbracken  (deleted user)

Corrected

Corrected

4:36 pm

wbracken  (deleted user)

Corrected

Corrected

3:03 pm

Vinayakam Mani

Done.

Done.

3:03 pm

Vinayakam Mani

Done.

Done.

2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

2:00 pm

Vinayakam Mani

DEN-16093 fixed merging conflicts

Options
    • -4
    • +5
    ./Heaters.c
  2. … 3 more files in changeset.
12:42 pm

Sean Nash

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

12:05 pm

Dara Navaei

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
Thursday 24 Aug 2023
2:02 pm

jtaylor  (deleted user)

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely re...

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.