Activity dgfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 31 Aug 2023

11:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
49a77f9
changed 1 file
develop

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

- -2
- +2
./Pressures.c
- History
- Source
- Diff
./Pressures.c

11:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
758a99a
changed 1 file
DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more DG-DEN-15973-1

DEN-15973 Requirements changes

- -2
- +3
./ROPump.c
- History
- Source
- Diff
./ROPump.c

2:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
5a76689
changed 2 files
DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more DG-DEN-15973-1

DEN-15973 Change to alarm limits and persistence values

- -2
- +2
./Pressures.c
- History
- Source
- Diff
./Pressures.c
- -2
- +4
./ROPump.c
- History
- Source
- Diff
./ROPump.c

1:09 pm

Dara Navaei

More
DG-DEN-16309-1
Closed

12:03 pm

Dara Navaei

More
51d6753
changed 7 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 68 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +2
./Pressures.c
- History
- Source
- Diff
./Pressures.c
… 4 more files in changeset.

9:51 am

wbracken (deleted user) and Sean Nash

More
DG-DEN-16309-1
finished reviewing

9:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:08 am

Dara Navaei

More
Re: DG-DEN-16309-1
replied to Sean Nash

Done.

Done.

8:55 am

Sean Nash

More
Re: DG-DEN-16309-1
commented on review

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Wednesday 30 Aug 2023

3:48 pm

Dara Navaei

More
16c0f81
changed 6 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
- -2
- +2
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
… 4 more files in changeset.

10:13 am

Dara Navaei

More
Re: DG-DEN-15973-1
commented on review

Please remove the blank line.

Please remove the blank line.

10:08 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
b37ec50
changed 1 file
DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more DG-DEN-15973-1

DEN-15973 Move max pwm check to execROPumpMonitor

- -6
- +5
./ROPump.c
- History
- Source
- Diff
./ROPump.c

Tuesday 29 Aug 2023

4:59 pm

Dara Navaei

More
28e9d54
changed 4 files
develop

Merged DEN-16309

- -2
- +2
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -10
- +14
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 2 more files in changeset.

2:07 pm

Dara Navaei

More
DG-DEN-15791-1
started review

DG-DEN-15791_DG Software Design Description

DG-DEN-15791_DG Software Design Description

1:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
76fc450
changed 3 files
develop

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

# Conflicts:

# firmware/App/DGCommon.h

- -4
- +5
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 2 more files in changeset.

1:25 pm

jtaylor (deleted user)

More
DG-DEN-16280-1
Closed

12:39 pm

jtaylor (deleted user)

More
DG-DEN-16309-1
resumed reviewing

9:03 am

jtaylor (deleted user)

More
DG-DEN-16093-1
finished reviewing

Monday 28 Aug 2023

2:25 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-16093-1
finished reviewing

10:22 am

Sean Nash

More
Re: DG-DEN-15973-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:21 am

Sean Nash

More
Re: DG-DEN-15973-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

Sean Nash

More
Re: DG-DEN-15973-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:08 am

Dara Navaei

9:08 am

Dara Navaei

8:43 am

Dara Navaei

More
12ccb89
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-16309-1

DEN-16309 added a new heat disinfect state

- -7
- +11
./Heaters.c
- History
- Source
- Diff
./Heaters.c
… 2 more files in changeset.

Sunday 27 Aug 2023

3:51 pm

Dara Navaei

More
4fbaa82
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-16309-1

DEN-16309 removed the clearance period some of the persistence alarms

- -2
- +2
./ConductivitySensors.c
- History
- Source
- Diff
./ConductivitySensors.c
- -3
- +3
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -4
- +4
./Pressures.c
- History
- Source
- Diff
./Pressures.c

Friday 25 Aug 2023

5:26 pm

wbracken (deleted user)

More
Re: DG-DEN-15973-1
replied to Sean Nash

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
4a57af4
changed 1 file
DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 63 more DG-DEN-15973-1

Merge branch 'staging' into DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment

- -1
- +3
./ROPump.c
- History
- Source
- Diff
./ROPump.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 02:41 -0700