Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALTHROUGH

RESOLVED in CODE WALTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Corrected

Corrected

Keep declarations at top of scope. Just have assignments down here.

Keep declarations at top of scope. Just have assignments down here.

Removed blank line

Removed blank line

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Please remove the blank line.

Please remove the blank line.

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the chec...

The ROPump PWM is set from 5 different calls. Doesn't look like there is a global indicating the last set PWM value (could add). The execROPumpMonitor function might be a good place to put the check as it looks to be able to handle different modes, but again doesn't have access to the last set PWM value.

Corrected

Corrected

Corrected

Corrected