dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Oct 2023
8:35 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./TemperatureSensors.c
Tuesday 03 Oct 2023
2:35 pm

jtaylor  (deleted user) and Sean Nash

2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

11:46 am

Vinayakam Mani

DEN-16395 fix merge issues

Options
    • -2
    • +2
    ./ROPump.h
  2. … 4 more files in changeset.
11:39 am

Vinayakam Mani

Done.

Done.

11:38 am

Vinayakam Mani

DEN-16395-code review changes

Options
    • -7
    • +1
    ./TemperatureSensors.c
10:37 am

Dara Navaei

Please remove these cases.

Please remove these cases.

Monday 02 Oct 2023
2:05 pm

Dara Navaei

DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
1:15 pm

Vinayakam Mani

DEN-16395 Dialysate temp out of range alarm changes

Options
    • -7
    • +27
    ./TemperatureSensors.c
Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:06 pm

Dara Navaei

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Options
    • -4
    • +4
    ./ROPump.c
  2. … 2 more files in changeset.
1:05 pm

Dara Navaei

1:03 pm

Dara Navaei and jtaylor  (deleted user)

1:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ConductivitySensors.h
    • -2
    • +2
    ./FlowSensors.c
    • -2
    • +2
    ./FluidLeak.c
    • -2
    • +2
    ./ROPump.c
    • -2
    • +2
    ./ROPump.h
  6. … 8 more files in changeset.
12:33 pm

Sean Nash

Merge branch 'DEN-15791-dg-software-design-description' into develop

Options
    • -2
    • +2
    ./ROPump.c
    • -8
    • +9
    ./ROPump.h
  3. … 7 more files in changeset.
11:41 am

Sean Nash

Merged staging to DEN-15791.

Options
    • -3
    • +15
    ./ROPump.c
  2. … 7 more files in changeset.
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
4:44 pm

Dara Navaei

DEN-16446 updated the code for VectorCAST changes

Options
    • -3
    • +3
    ./ROPump.c
11:18 am

Dara Navaei

DEN-16446 updated the code and VectorCAST test cases

Options
    • -0
    • +4
    ./Pressures.c
  2. … 1 more file in changeset.
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Tuesday 26 Sep 2023
5:17 pm

Vinayakam Mani

DEN-16446 vecor cast unit test updates

Options
    • -0
    • +2
    ./Valves.c
Saturday 23 Sep 2023
4:48 pm

Dara Navaei

DEN-16446 updated the code and VectorCAST tests

Options
    • -1
    • +1
    ./Heaters.c
  2. … 1 more file in changeset.
Friday 22 Sep 2023
3:32 pm

Sean Nash

DEN-15791: Doxygen comment fixes.

Options
    • -3
    • +0
    ./ConductivitySensors.h
    • -5
    • +5
    ./FlowSensors.c
    • -3
    • +0
    ./FluidLeak.c
    • -2
    • +2
    ./ROPump.c
    • -8
    • +9
    ./ROPump.h
  6. … 2 more files in changeset.