Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-16475: code review comments

Add doxygen comment.

Add doxygen comment.

DG-DEN-16475_Please Add Average Tdi Tro Delta
DG-DEN-16475_Please Add Average Tdi Tro Delta
DEN-16475: added temperature event for drift during chem disinfect

sizeof should be first in if

sizeof should be first in if

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

Resolved in code review.

Resolved in code review.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

DEN-16395 fix merge issues

  1. … 4 more files in changeset.
Done.

Done.

DEN-16395-code review changes

Please remove these cases.

Please remove these cases.

DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
DEN-16395 Dialysate temp out of range alarm changes

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 8 more files in changeset.
Merge branch 'DEN-15791-dg-software-design-description' into develop

  1. … 7 more files in changeset.
Merged staging to DEN-15791.

  1. … 7 more files in changeset.
The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

DEN-16446 updated the code for VectorCAST changes