dgfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Oct 2023
8:57 am

Michael Garthwaite

DEN-16475: code review comments

Options
    • -1
    • +1
    ./TemperatureSensors.c
8:51 am

Sean Nash

Add doxygen comment.

Add doxygen comment.

8:05 am

Dara Navaei

DG-DEN-16475_Please Add Average Tdi Tro Delta
DG-DEN-16475_Please Add Average Tdi Tro Delta
7:59 am

Michael Garthwaite

DEN-16475: added temperature event for drift during chem disinfect

Options
    • -0
    • +15
    ./TemperatureSensors.c
Sunday 08 Oct 2023
5:55 pm

wbracken  (deleted user)

sizeof should be first in if

sizeof should be first in if

Friday 06 Oct 2023
10:19 am

wbracken  (deleted user)

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken  (deleted user)

Resolved in code review.

Resolved in code review.

Wednesday 04 Oct 2023
8:41 am

Vinayakam Mani

8:39 am

Dara Navaei

8:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

8:35 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./TemperatureSensors.c
Tuesday 03 Oct 2023
2:35 pm

jtaylor  (deleted user) and Sean Nash

2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

11:46 am

Vinayakam Mani

DEN-16395 fix merge issues

Options
    • -2
    • +2
    ./ROPump.h
  2. … 4 more files in changeset.
11:39 am

Vinayakam Mani

Done.

Done.

11:38 am

Vinayakam Mani

DEN-16395-code review changes

Options
    • -7
    • +1
    ./TemperatureSensors.c
10:37 am

Dara Navaei

Please remove these cases.

Please remove these cases.

Monday 02 Oct 2023
2:05 pm

Dara Navaei

DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
DG-DEN-16395_FW Remove Tro Tdi Check From Post Treatment Modes And During Water Flush And Chem Flush
1:15 pm

Vinayakam Mani

DEN-16395 Dialysate temp out of range alarm changes

Options
    • -7
    • +27
    ./TemperatureSensors.c
Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:06 pm

Dara Navaei

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Options
    • -4
    • +4
    ./ROPump.c
  2. … 2 more files in changeset.
1:05 pm

Dara Navaei

1:03 pm

Dara Navaei and jtaylor  (deleted user)

1:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ConductivitySensors.h
    • -2
    • +2
    ./FlowSensors.c
    • -2
    • +2
    ./FluidLeak.c
    • -2
    • +2
    ./ROPump.c
    • -2
    • +2
    ./ROPump.h
  6. … 8 more files in changeset.
12:33 pm

Sean Nash

Merge branch 'DEN-15791-dg-software-design-description' into develop

Options
    • -2
    • +2
    ./ROPump.c
    • -8
    • +9
    ./ROPump.h
  3. … 7 more files in changeset.
11:41 am

Sean Nash

Merged staging to DEN-15791.

Options
    • -3
    • +15
    ./ROPump.c
  2. … 7 more files in changeset.
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
4:44 pm

Dara Navaei

DEN-16446 updated the code for VectorCAST changes

Options
    • -3
    • +3
    ./ROPump.c