Drivers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-16446 Dev test clean up

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Done

Done

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met
DEN-16308 updated the DG watchdog and safety shutdown POSTs

  1. … 3 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
DEN-16250 removed the voltage check code

  1. … 1 more file in changeset.
DEN-16250 updated the voltages in the watchdog and safety shutdown

  1. … 1 more file in changeset.
DEN-16250 fixed the logic in the voltages check in watchdog and safety shutdown

  1. … 1 more file in changeset.
DEN-16250 added the isolated voltage to the watchdog and safety shutdown POSTs

  1. … 1 more file in changeset.
DG-DEN-16250_Flow Check Alarm 207 When Filling With Pause State
DG-DEN-16250_Flow Check Alarm 207 When Filling With Pause State