ModeHeatDisinfect.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Merged release/p1b/staging

  1. … 5 more files in changeset.
DENBUG-298 updated the code from staging

  1. … 5 more files in changeset.
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

DENBUG-307 updated the heat disinfect to run the concentration pumps for the duration of heat disinfect from the time that the reservoirs are filled up until the end of disinfect R2 to R1

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-17234 addressed the code review comments

  1. … 1 more file in changeset.
Done

Done

No

No

Are these permanent changes?

Are these permanent changes?