ModeInitPOST.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

hd mode should be >= standby mode. You have it backward.

hd mode should be >= standby mode. You have it backward.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

  1. … 1 more file in changeset.
DENBUG-318 added code to keep requesting DG institutional values once start DG has been sent until the values are received

  1. … 3 more files in changeset.
Should we have before and after values in event data?

Should we have before and after values in event data?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed. UI is updated too.

Removed. UI is updated too.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DENBUG-318

  1. … 4 more files in changeset.
DENBUG-318 updated the code to receive all the DG institutional record items. Added code to use the min inlet water conductivity alarm from the institutional record

  1. … 6 more files in changeset.
Done

Done

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I don't see the flag being set in this function.

I don't see the flag being set in this function.

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

max ratio

max ratio

DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
Merged DEN-17234

  1. … 12 more files in changeset.