dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Aug 2021
2:50 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Added 5 minutes wait time for HD comm timeout before transition back to standby

Options
    • -6
    • +0
    ./ModeDrain.c
    • -6
    • +0
    ./ModeFill.c
    • -2
    • +14
    ./ModeGenIdle.c
10:57 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Fixed out of range check error

Options
    • -2
    • +2
    ./ModeFill.c
10:38 am

Sean Nash

The max part of these do not look right (backward).

The max part of these do not look right (backward).

Thursday 26 Aug 2021
4:44 pm

Quang Nguyen <qnguyen@diality.com>

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

Options
    • -11
    • +11
    ./OperationModes.c
  2. … 4 more files in changeset.
11:35 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Turned off concentrate pumps when water is not ready

Options
    • -0
    • +2
    ./ModeFill.c
Wednesday 25 Aug 2021
10:38 am

Dara Navaei

DEN-9480 worked on developing new heaters control

Options
    • -2
    • +2
    ./ModeFault.c
    • -1
    • +1
    ./ModeFlush.c
    • -9
    • +14
    ./ModeRecirculate.c
    • -1
    • +3
    ./ModeStandby.c
  5. … 7 more files in changeset.
Tuesday 24 Aug 2021
4:24 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Renamed re-circ to generation idle

Options
    • -4
    • +3
    ./ModeFill.c
    • -3
    • +3
    ./ModeGenIdle.c
  3. … 2 more files in changeset.
Thursday 19 Aug 2021
2:02 pm

Sean Nash

2:01 pm

qnguyen  (deleted user) and Dara Navaei

1:17 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Used test support get override value

Options
    • -21
    • +1
    ./ModeStandby.c
  2. … 17 more files in changeset.
10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen  (deleted user)

Done.

Done.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:29 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

qnguyen  (deleted user)

Done.

Done.

10:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Addressed code review comments

Options
    • -4
    • +4
    ./ModeChemicalDisinfect.c
    • -2
    • +2
    ./ModeFault.c
    • -58
    • +19
    ./ModeFill.c
    • -4
    • +4
    ./ModeFlush.c
    • -2
    • +2
    ./ModeGenIdle.c
    • -4
    • +4
    ./ModeHeatDisinfect.c
  7. … 3 more files in changeset.
10:10 am

qnguyen  (deleted user)

Done.

Done.

10:10 am

qnguyen  (deleted user)

Done.

Done.

10:08 am

qnguyen  (deleted user)

Done.

Done.

9:26 am

Sean Nash

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

9:26 am

qnguyen  (deleted user)

Removed.

Removed.

9:25 am

Sean Nash

Start comments w/ capital letter.

Start comments w/ capital letter.

9:23 am

Sean Nash

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

9:22 am

Sean Nash

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know acid pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.