Activity dgfirmware/firmware/App/Modes

5:16 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

We should probably keep the = 0;

4:01 pm

Dara Navaei

More
Re: DG-DEN-11750-1
commented on review

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

More
Re: DG-DEN-11750-1
commented on review

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:47 pm

Dara Navaei

More
DG-DEN-11750-1
started review

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

7:09 pm

Dara Navaei

More
DG-DEN-11114-1
Closed

5:21 pm

hnguyen (deleted user) and Sean Nash

More
DG-DEN-11114-1
finished reviewing

10:30 am

hnguyen (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:30 am

hnguyen (deleted user)

RESOLVED IN CODE WALKTHROUGH

10:29 am

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

hnguyen (deleted user) and Sean Nash

hnguyen (deleted user)

hnguyen (deleted user)