dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 25 Feb 2022
2:28 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Removed blank lines

Options
    • -4
    • +2
    ./ModeFill.c
  2. … 1 more file in changeset.
2:24 pm

Sean Nash

Looks like this needs to be addressed.

Looks like this needs to be addressed.

2:20 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Removed 5 secs persistent conductivity test SRSDG 558 & SRSDG 630

Options
    • -29
    • +3
    ./ModeFill.c
  2. … 1 more file in changeset.
11:02 am

Sean Nash

Magic #.

Magic #.

10:58 am

Sean Nash

rpm should be in ().

rpm should be in ().

10:56 am

Sean Nash

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

10:42 am

Sean Nash

There are 2 functions in this module with this name.

There are 2 functions in this module with this name.

8:57 am

Sean Nash

Are these really common? Can they be moved to sys_selftest.c?

Are these really common? Can they be moved to sys_selftest.c?

8:57 am

Dara Navaei

DG-DEN-11928_DG Conductivity Update
DG-DEN-11928_DG Conductivity Update
8:53 am

Sean Nash

Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around these definitions and all other build switch related code.

8:51 am

Sean Nash

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this structure.

8:51 am

Sean Nash

Add #ifndef RELEASE around this enum.

Add #ifndef RELEASE around this enum.

8:50 am

Sean Nash

Should be #ifndef RELEASE around this structure.

Should be #ifndef RELEASE around this structure.

8:50 am

Sean Nash

I think there should be a #ifndef RELEASE around these build switches.

I think there should be a #ifndef RELEASE around these build switches.

8:46 am

Sean Nash

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Thursday 24 Feb 2022
6:03 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated deliver dialysate state

Options
    • -29
    • +57
    ./ModeFill.c
  2. … 1 more file in changeset.
3:36 pm

Michael Garthwaite

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

3:33 pm

Michael Garthwaite

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Do we need an if for an always true condition? does this branch statement need to be uncommented?

3:25 pm

Michael Garthwaite

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

3:17 pm

Michael Garthwaite

I think this alarm should be not commented out.

I think this alarm should be not commented out.

Wednesday 23 Feb 2022
8:28 pm

Dara Navaei

Merge branch 'DEN-11928-dg-conductivity-update-den-tbd' into develop

Options
    • -127
    • +254
    ./ModeFill.c
  2. … 3 more files in changeset.
3:29 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated conductivity test

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.
3:00 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature out of range test

Options
    • -1
    • +2
    ./ModeFill.c
  2. … 1 more file in changeset.
2:08 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated temperature, rejection ratio, CPo with new values

Options
    • -14
    • +13
    ./ModeFill.c
  2. … 2 more files in changeset.
10:14 am

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Implemented conductivity updates

Options
    • -116
    • +242
    ./ModeFill.c
  2. … 2 more files in changeset.
Tuesday 22 Feb 2022
5:16 pm

Michael Garthwaite

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

We should probably keep the = 0;

We should probably keep the = 0;

4:01 pm

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.