dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 Jul 2022
1:30 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13549 Correct reservoir volume logic to match requirements. Changed ">" to ">=" in several modes when checking for R1 being filled before R2

Options
    • -3
    • +3
    ./ModeChemicalDisinfect.c
    • -1
    • +1
    ./ModeFlush.c
    • -2
    • +2
    ./ModeHeatDisinfect.c
10:37 am

Sean Nash

Should be s/w fault. Add TODO or trigger s/w fault now.

Should be s/w fault. Add TODO or trigger s/w fault now.

10:36 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:34 am

Sean Nash

This assignment should be done above at declaration. Move calStatus declaration above result.

This assignment should be done above at declaration. Move calStatus declaration above result.

10:31 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:17 am

Sean Nash

Do either of these 2 if statements need an else?

Do either of these 2 if statements need an else?

10:15 am

Sean Nash

Blank line between declarations and code.

Blank line between declarations and code.

10:12 am

Sean Nash

Prefer normal if else for calling functions. I see these throughout.

Prefer normal if else for calling functions. I see these throughout.

9:04 am

Sean Nash

What is the point in having these locals? Why not just use the concentratePumps fields directly?

What is the point in having these locals? Why not just use the concentratePumps fields directly?

9:01 am

Sean Nash

This blank line should stay - style is to have blank lines between declarations and code.

This blank line should stay - style is to have blank lines between declarations and code.

9:00 am

Sean Nash

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Monday 18 Jul 2022
4:13 pm

Dara Navaei

DEN-13460 updated the code with DVT features

Options
    • -0
    • +4
    ./ModeFault.c
    • -1
    • +1
    ./ModeFill.c
  3. … 12 more files in changeset.
Friday 15 Jul 2022
3:50 pm

Dara Navaei

Merged DEN-12931

Options
    • -1
    • +1
    ./OperationModes.c
  2. … 3 more files in changeset.
3:44 pm

Dara Navaei

DEN-12931 updated the dialysate flow sensor and made switching to service mode legal from solo mode

Options
    • -1
    • +1
    ./OperationModes.c
  2. … 1 more file in changeset.
Thursday 14 Jul 2022
6:34 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge remote-tracking branch 'origin/DEN-12974-miscellaneous-flush-issues_bb' into develop

Options
    • -8
    • +10
    ./ModeFlush.c
    • -2
    • +5
    ./ModeHeatDisinfect.c
  3. … 2 more files in changeset.
6:14 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13425 Remove logic around resetting state timer for getRsrvrFillStatus.

Options
    • -9
    • +8
    ./ModeFlush.c
5:45 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974

Options
    • -11
    • +14
    ./ModeFlush.c
    • -0
    • +1
    ./ModeHeatDisinfect.c
2:59 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13425 Unable to set default arguement.

Options
    • -6
    • +6
    ./ModeFlush.c
2:16 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13425 Correct bool to BOOL

Options
    • -3
    • +3
    ./ModeFlush.c
    • -2
    • +4
    ./ModeHeatDisinfect.c
1:08 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13425 Do not reset state timer in FlushR2DrainR1

Options
    • -4
    • +4
    ./ModeFlush.c
Wednesday 13 Jul 2022
3:50 pm

Dara Navaei

Merged DEN-12931

Options
    • -0
    • +7
    ./ModeInitPOST.c
  2. … 11 more files in changeset.
Tuesday 12 Jul 2022
6:24 pm

Dara Navaei

DEN-12931 updated the drivers with the DVT changes. Added code to run RTC and NVDataMgmt POSTs at fault mode

Options
    • -4
    • +63
    ./ModeFault.c
  2. … 8 more files in changeset.
Friday 08 Jul 2022
6:04 pm

Sean Nash

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

Options
    • -0
    • +28
    ./OperationModes.c
  2. … 3 more files in changeset.
5:56 pm

Sean Nash

DEN-13427: Added support for Dialin request to go to service mode.

Options
    • -0
    • +28
    ./OperationModes.c
    • -0
    • +1
    ./OperationModes.h
  3. … 3 more files in changeset.
Thursday 07 Jul 2022
7:05 am

Dara Navaei

DG-DEN-12931_DG HD Dev HD DG Dvt Update
DG-DEN-12931_DG HD Dev HD DG Dvt Update
Wednesday 06 Jul 2022
9:52 pm

Dara Navaei

DEN-12931 updated the drviers with DVT changes

Options
    • -0
    • +7
    ./ModeInitPOST.c
    • -0
    • +1
    ./ModeService.c
  3. … 16 more files in changeset.
1:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-12974, DEN-13078 correct setting of VPo when entering handleFlushModeDrainR2State.

Options
    • -0
    • +1
    ./ModeFlush.c
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Tuesday 28 Jun 2022
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.