Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Should be s/w fault. Add TODO or trigger s/w fault now.

Should be s/w fault. Add TODO or trigger s/w fault now.

Blank line between declarations and code.

Blank line between declarations and code.

This assignment should be done above at declaration. Move calStatus declaration above result.

This assignment should be done above at declaration. Move calStatus declaration above result.

Keep this blank line.

Keep this blank line.

Do either of these 2 if statements need an else?

Do either of these 2 if statements need an else?

Blank line between declarations and code.

Blank line between declarations and code.

Prefer normal if else for calling functions. I see these throughout.

Prefer normal if else for calling functions. I see these throughout.

What is the point in having these locals? Why not just use the concentratePumps fields directly?

What is the point in having these locals? Why not just use the concentratePumps fields directly?

This blank line should stay - style is to have blank lines between declarations and code.

This blank line should stay - style is to have blank lines between declarations and code.

Define disable (even if not used) so it is clear which bit position controls enable/disable.

Define disable (even if not used) so it is clear which bit position controls enable/disable.

DG-DEN-12931_DG HD Dev HD DG Dvt Update
DG-DEN-12931_DG HD Dev HD DG Dvt Update
That would also require a change to the requirements.

That would also require a change to the requirements.

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

Removed blank line

Removed blank line

Will add back in.

Will add back in.

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

Can we remove this code now?

Can we remove this code now?

Why is this commented out?

Why is this commented out?

Can we just remove this code now?

Can we just remove this code now?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Why is this alarm commented out?

Why is this alarm commented out?

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

Remove extra blank line.

Remove extra blank line.

Why did this change? I think it's needed for doxygen.

Why did this change? I think it's needed for doxygen.