dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Jan 2023
4:05 pm

Dara Navaei

DEN-14559 addressed the code review comments

Options
    • -13
    • +24
    ./ModeChemicalDisinfect.c
    • -1
    • +1
    ./ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./ModeFlush.c
    • -1
    • +1
    ./ModeHeatDisinfect.c
  5. … 2 more files in changeset.
4:03 pm

Dara Navaei

Done

Done

4:02 pm

Dara Navaei

Done.

Done.

4:00 pm

Dara Navaei

Done

Done

3:59 pm

Dara Navaei

Done

Done

3:58 pm

Dara Navaei

Done.

Done.

3:56 pm

Dara Navaei

Done

Done

3:55 pm

Dara Navaei

DOne

DOne

3:54 pm

Dara Navaei

No, this code has been removed.

No, this code has been removed.

3:54 pm

Dara Navaei

This alarm is still available.

This alarm is still available.

3:51 pm

Dara Navaei

That is true. I tested these functions and they reset only the minimum (necessary) variables.

That is true. I tested these functions and they reset only the minimum (necessary) variables.

3:49 pm

Dara Navaei

No, at this point we are done with the variable.

No, at this point we are done with the variable.

3:49 pm

Dara Navaei

Done

Done

3:46 pm

Dara Navaei

Done.

Done.

3:43 pm

Dara Navaei

Done

Done

3:36 pm

Dara Navaei

Merge branch 'staging' into DEN-14559-dg_hd_dev-hd_dg_dvt-update-part-8

Options
    • -5
    • +18
    ./ModeDrain.c
  2. … 4 more files in changeset.
3:34 pm

Dara Navaei

DEN-14559 updated the code to be able request POST by the Dialin user. Updated the chemical disinfect flush to be able drain the reservoirs all the time

Options
    • -7
    • +7
    ./ModeChemicalDisinfect.c
    • -23
    • +22
    ./ModeChemicalDisinfectFlush.c
    • -2
    • +2
    ./ModeDrain.c
    • -7
    • +10
    ./ModeFlush.c
    • -8
    • +8
    ./ModeHeatDisinfect.c
    • -12
    • +6
    ./ModeStandby.c
  7. … 5 more files in changeset.
2:11 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeDrain.c
  2. … 9 more files in changeset.
12:53 pm

wbracken  (deleted user)

11:29 am

Michael Garthwaite and dcox  (deleted user)

Tuesday 17 Jan 2023
10:23 pm

Dara Navaei

10:23 pm

Dara Navaei

3:46 pm

Sean Nash

3:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:08 pm

wbracken  (deleted user)

Seems like there are several variables missing.

Seems like there are several variables missing.

3:01 pm

Dara Navaei

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
2:28 pm

wbracken  (deleted user)

Removed

Removed

2:27 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13676 Correction per code review

Options
    • -2
    • +0
    ./ModeDrain.c
1:49 pm

Sean Nash

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

1:43 pm

Sean Nash

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.