dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Jan 2023
4:03 pm

Dara Navaei

Done

Done

4:02 pm

Dara Navaei

Done.

Done.

4:00 pm

Dara Navaei

Done

Done

3:59 pm

Dara Navaei

Done

Done

3:58 pm

Dara Navaei

Done.

Done.

3:56 pm

Dara Navaei

Done

Done

3:55 pm

Dara Navaei

DOne

DOne

3:54 pm

Dara Navaei

No, this code has been removed.

No, this code has been removed.

3:54 pm

Dara Navaei

This alarm is still available.

This alarm is still available.

3:51 pm

Dara Navaei

That is true. I tested these functions and they reset only the minimum (necessary) variables.

That is true. I tested these functions and they reset only the minimum (necessary) variables.

3:49 pm

Dara Navaei

No, at this point we are done with the variable.

No, at this point we are done with the variable.

3:49 pm

Dara Navaei

Done

Done

3:46 pm

Dara Navaei

Done.

Done.

3:43 pm

Dara Navaei

Done

Done

12:53 pm

wbracken  (deleted user)

11:29 am

Michael Garthwaite and dcox  (deleted user)

Tuesday 17 Jan 2023
10:23 pm

Dara Navaei

10:23 pm

Dara Navaei

3:46 pm

Sean Nash

3:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:08 pm

wbracken  (deleted user)

Seems like there are several variables missing.

Seems like there are several variables missing.

3:01 pm

Dara Navaei

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
2:28 pm

wbracken  (deleted user)

Removed

Removed

1:49 pm

Sean Nash

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

1:43 pm

Sean Nash

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

1:41 pm

Sean Nash

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

1:36 pm

Sean Nash

Need to be careful with these. These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override v...

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

1:24 pm

Sean Nash

Variable should already be a BOOL.

Variable should already be a BOOL.

1:24 pm

Sean Nash

Set to TRUE here.

Set to TRUE here.

1:23 pm

Sean Nash

Initialize to FALSE.

Initialize to FALSE.