dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
7:49 pm

Dara Navaei

Merged staging

Options
    • -16
    • +29
    ./ModeFill.c
  2. … 5 more files in changeset.
7:40 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
    • -1
    • +1
    ./ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +1
    ./ModeFill.h
    • -2
    • +2
    ./ModeFlush.c
    • -1
    • +1
    ./ModeHeatDisinfect.c
    • -1
    • +1
    ./ModeHeatDisinfectActiveCool.c
    • -1
    • +1
    ./ModeStandby.c
  9. … 10 more files in changeset.
4:21 pm

Dara Navaei

3:52 pm

Sean Nash and dcox  (deleted user)

3:18 pm

Michael Garthwaite

9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

Thursday 30 Mar 2023
9:20 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table changes

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
    • -1
    • +1
    ./ModeChemicalDisinfectFlush.c
    • -15
    • +28
    ./ModeFill.c
    • -1
    • +1
    ./ModeFlush.c
    • -1
    • +1
    ./ModeHeatDisinfect.c
    • -1
    • +1
    ./ModeHeatDisinfectActiveCool.c
    • -3
    • +45
    ./ModeStandby.c
  8. … 1 more file in changeset.
8:18 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table update

Options
    • -1
    • +1
    ./ModeChemicalDisinfect.c
    • -1
    • +6
    ./ModeChemicalDisinfectFlush.c
    • -2
    • +6
    ./ModeFlush.c
    • -2
    • +6
    ./ModeHeatDisinfect.c
    • -2
    • +6
    ./ModeHeatDisinfectActiveCool.c
  6. … 4 more files in changeset.
7:04 pm

Dara Navaei

Merged DEN-14999

Options
    • -14
    • +110
    ./ModeFill.c
    • -1
    • +3
    ./ModeInitPOST.c
  3. … 4 more files in changeset.
2:37 pm

Dara Navaei

DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

Options
    • -6
    • +47
    ./ModeFill.c
    • -0
    • +2
    ./ModeFill.h
    • -1
    • +1
    ./ModeStandby.c
  4. … 3 more files in changeset.
Wednesday 29 Mar 2023
11:22 am

Dara Navaei

DEN-13674, DEN-13675 changed the fill mode to be able to restart fill if the acid and bicarb conducitivies are out of range

Options
    • -2
    • +27
    ./ModeFill.c
8:48 am

Dara Navaei

Merge branch 'staging' into DEN-14999-alarm-table-updates

Options
    • -6
    • +35
    ./ModeFill.c
8:40 am

Dara Navaei

DEN-14999 added a blank line

Options
    • -0
    • +1
    ./ModeFill.c
8:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeFill.c
    • -2
    • +2
    ./ModeFill.h
    • -1
    • +1
    ./ModeInitPOST.c
  4. … 5 more files in changeset.
8:37 am

Dara Navaei

8:08 am

Sean Nash

Tuesday 28 Mar 2023
5:19 pm

Dara Navaei

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Dara Navaei

Done

Done

5:03 pm

Sean Nash

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

5:00 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

Dara Navaei

Check the diff of the last two commits.

Check the diff of the last two commits.

4:58 pm

Sean Nash

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

4:58 pm

Dara Navaei

Done

Done

4:57 pm

Sean Nash

Remove TODO?

Remove TODO?

4:57 pm

Dara Navaei

DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FALSE every time

Options
    • -2
    • +3
    ./ModeFill.c
4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.