Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-14999-alarm-table-updates-part-2' into develop

DEN-14999 added 5-second delays prior to collecting acid and bicarb conductivity values during acid and bicarb priming

Changed the heat disinfect transfer flow to 0.5 L/min from 0.8 L/min

DG-DEN-14999_Alarm Table Updates Part 2
DG-DEN-14999_Alarm Table Updates Part 2
Merged staging

  1. … 5 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 10 more files in changeset.
RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

DEN-14999 updated the code based on the alarms table changes

  1. … 1 more file in changeset.
DEN-14999 updated the code based on the alarms table update

  1. … 4 more files in changeset.
Merged DEN-14999

  1. … 4 more files in changeset.
DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

  1. … 3 more files in changeset.
DEN-13674, DEN-13675 changed the fill mode to be able to restart fill if the acid and bicarb conducitivies are out of range

Merge branch 'staging' into DEN-14999-alarm-table-updates

DEN-14999 added a blank line

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.