dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 25 Aug 2023
2:52 pm

Vinayakam Mani

DEN-16093 code review comments added

Options
    • -2
    • +5
    ./ModeFill.c
2:50 pm

Vinayakam Mani

DEN-16093 fixed code review comments

Options
    • -2
    • +5
    ./ModeFill.c
2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

2:00 pm

Vinayakam Mani

DEN-16093 fixed merging conflicts

Options
    • -3
    • +3
    ./ModeFill.c
  2. … 3 more files in changeset.
1:21 pm

Vinayakam Mani

DEN-16093-Increased conductivity percentage check and time out values

Options
    • -3
    • +3
    ./ModeFill.c
1:06 pm

Vinayakam Mani

take latest changes from staging

Options
    • -5
    • +13
    ./ModeFill.c
  2. … 3 more files in changeset.
12:05 pm

Dara Navaei

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
Thursday 24 Aug 2023
3:42 pm

Dara Navaei

3:41 pm

Dara Navaei

12:37 pm

wbracken  (deleted user) , Sean Nash and jtaylor  (deleted user)

9:57 am

Dara Navaei

DG-DIAL-276_DG Event Event ID 15 Prints Duplicate Events With Different State Time
DG-DIAL-276_DG Event Event ID 15 Prints Duplicate Events With Different State Time
9:48 am

Michael Garthwaite

DIAL-276: fixed op status event duplicating on op mode change only.

Options
    • -2
    • +1
    ./OperationModes.c
Wednesday 23 Aug 2023
11:55 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

Options
    • -3
    • +2
    ./ModeFill.c
  2. … 5 more files in changeset.
10:32 am

Vinayakam Mani

DEN-16093-merge in to develop

Options
    • -5
    • +5
    ./ModeFill.c
  2. … 1 more file in changeset.
10:21 am

Vinayakam Mani

DEN-16093-changed prime Max time and conductivity poercent check

Options
    • -5
    • +5
    ./ModeFill.c
Tuesday 22 Aug 2023
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

Friday 18 Aug 2023
1:50 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 2 more files in changeset.
1:49 pm

Dara Navaei

1:48 pm

Sean Nash and wbracken  (deleted user)

1:45 pm

Dara Navaei

DEN-16250 updated doxygen comment

Options
    • -2
    • +1
    ./ModeFill.c
Thursday 17 Aug 2023
2:51 pm

Dara Navaei

Merge branch 'DEN-16250-flow-check-alarm-207-when-filling-with-pause-state' into develop

Options
    • -5
    • +13
    ./ModeFill.c
2:50 pm

Dara Navaei

DEN-15250 addressed alarm 207

Options
    • -5
    • +13
    ./ModeFill.c
2:04 pm

Dara Navaei

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment