Activity dgfirmware/firmware/App/Modes

4:56 pm

Dara Navaei

More
7980373
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-16309-1

DEN-16323, DEN-16277 updated the chemical disinfect to get the level of the reservoir under disinfection more accurately

- -20
- +59
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c

2:07 pm

Dara Navaei

More
DG-DEN-15791-1
started review

DG-DEN-15791_DG Software Design Description

12:39 pm

jtaylor (deleted user)

More
DG-DEN-16309-1
resumed reviewing

12:38 pm

Dara Navaei

More
f245559
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-16309-1

DEN-16309 updated the code. Changed the load cells' full level from 1900 to 1850 mL in heat disinfect to be consistent with the rest of the cleaning modes

- -0
- +1
./ModeFault.c
- History
- Source
- Diff
./ModeFault.c
- -1
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

12:32 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:39 am

Michael Garthwaite

More
0bfc0cf
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DIAL-281-1

DIAL-281: Code review comments.

- -3
- +3
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

11:37 am

Michael Garthwaite

More
Re: DG-DIAL-281-1
replied to Dara Navaei

Fixed. Thanks!

10:30 am

Dara Navaei

More
Re: DG-DIAL-281-1
commented on review

Please add _MS to be consistent with the reset of times which are all in milliseconds.

9:34 am

Michael Garthwaite

More
6703d91
changed 5 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DIAL-281-1

DIAL-278: implementation of heat disinfection state timer overrides.

- -4
- +105
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -0
- +4
./ModeHeatDisinfect.h
- History
- Source
- Diff
./ModeHeatDisinfect.h
… 3 more files in changeset.

9:03 am

jtaylor (deleted user)

More
DG-DEN-16093-1
finished reviewing

2:25 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-16093-1
finished reviewing

2:06 pm

Dara Navaei

More
DG-DIAL-281-1
started review

DG-DIAL-281_Requesting Heat Disinfect Timer Overrides

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:36 am

Dara Navaei

More
7ba136c
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c

9:31 am

Dara Navaei

More
12ccb89
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-16309-1

DEN-16309 added a new heat disinfect state

- -10
- +62
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -0
- +1
./ModeHeatDisinfect.h
- History
- Source
- Diff
./ModeHeatDisinfect.h
… 1 more file in changeset.

3:03 pm

Vinayakam Mani

More
Re: DG-DEN-16093-1
replied to Sean Nash

Done.

3:03 pm

Vinayakam Mani

More
Re: DG-DEN-16093-1
replied to Sean Nash

Done.

2:52 pm

Vinayakam Mani

More
79d199f
changed 1 file
develop

DEN-16093 code review comments added

- -2
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

2:50 pm

Vinayakam Mani

More
6e49f49
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093 fixed code review comments

- -2
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

2:27 pm

Sean Nash

More
Re: DG-DEN-16093-1
commented on review

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm