dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Sep 2023
10:27 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -4
    • +4
    ./ModeStandby.c
9:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

9:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

Dara Navaei

9:48 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -1
    • +5
    ./ModeStandby.c
    • -1
    • +1
    ./OperationModes.h
  3. … 1 more file in changeset.
9:44 am

Dara Navaei

Done

Done

9:42 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

You at least need to add a comment explaining what they are.

You at least need to add a comment explaining what they are.

9:38 am

Dara Navaei

Done

Done

9:37 am

Sean Nash

No, these are the minimum values to trigger the alarm. But they are named maximums.

No, these are the minimum values to trigger the alarm. But they are named maximums.

9:37 am

Dara Navaei

Yes these are for software configuration disable only so I did not make any #defines for them.

Yes these are for software configuration disable only so I did not make any #defines for them.

9:37 am

Sean Nash

Yes, so name should reflect that. These names suggest they are minimum pressures below which we would alarm.

Yes, so name should reflect that. These names suggest they are minimum pressures below which we would alarm.

9:35 am

Sean Nash

Align comment.

Align comment.

9:35 am

Sean Nash

Magic numbers?

Magic numbers?

9:32 am

Dara Navaei

This is the minimum values that are needed to clear the alarm.

This is the minimum values that are needed to clear the alarm.

9:32 am

Dara Navaei

This is the minimum values that are needed to clear the alarm.

This is the minimum values that are needed to clear the alarm.

9:30 am

Sean Nash

These 2 values appear to be minimum recovery thresholds.

These 2 values appear to be minimum recovery thresholds.

9:29 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeChemicalDisinfect.c
    • -2
    • +2
    ./ModeChemicalDisinfect.h
  3. … 3 more files in changeset.
9:29 am

Sean Nash

These to values appear to be minimums. Why are they being called maximums?

These to values appear to be minimums. Why are they being called maximums?

9:28 am

Michael Garthwaite

9:03 am

Dara Navaei

9:02 am

Dara Navaei

9:00 am

Dara Navaei and wbracken  (deleted user)

Wednesday 13 Sep 2023
4:48 pm

Vinayakam Mani

4:47 pm

Dara Navaei

DEN-15973 fixed the inlet water pressure alarm. DEN-16418 added chemical flush done after chemical disinfect prior to starting RO permeate sample mode

Options
    • -0
    • +11
    ./ModeStandby.c
  2. … 1 more file in changeset.
11:04 am

Dara Navaei

DEN-15973 added the inlet water pressure limit in flush drain in the cleaning modes

Options
    • -0
    • +12
    ./OperationModes.c
    • -0
    • +1
    ./OperationModes.h
  3. … 1 more file in changeset.
9:53 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low' into develop

Options
    • -17
    • +12
    ./ModeFill.c
9:52 am

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

On Dara's advice, ifdef'ed code for fill state treatment recovery

Options
    • -17
    • +12
    ./ModeFill.c