Activity dgfirmware/firmware/App/Modes

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

11:18 am

Dara Navaei

More
fa508da
changed 2 files
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more DG-DEN-16446-1

DEN-16446 updated the code and VectorCAST test cases

- -0
- +3
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
… 1 more file in changeset.

8:56 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to jtaylor (deleted user)

Done

8:56 am

Dara Navaei

More
1d97505
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more DG-DEN-16446-1

DEN-16446 addressed the code review comment

- -1
- +4
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

8:33 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to Sean Nash

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to jtaylor (deleted user)

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

4:40 pm

jtaylor (deleted user)

More
Re: DG-DEN-16446-1
commented on review

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

3:32 pm

Dara Navaei

More
2f7745c
changed 2 files
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more DG-DEN-16446-1

DEN-16446 updated the code for VectorCAST

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +3
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

1:07 pm

Sean Nash

More
Re: DG-DEN-16446-1
commented on review

What's left? When would this code ever become reachable?

8:57 am

Dara Navaei

More
1854144
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more DG-DEN-16446-1

DEN-16446 updated the code and VectorCAST test cases

- -1
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

8:30 am

jtaylor (deleted user)

More
Re: DG-DEN-16446-1
commented on review

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

2:55 pm