dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Oct 2023
5:26 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-16466-alarm-282-dg-bicarbonate-concentration-bottle-low-volume-triggers-after-treatment' into develop

# Conflicts:

# firmware/App/DGCommon.h

Options
    • -4
    • +18
    ./ModeDrain.c
10:19 am

wbracken  (deleted user)

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken  (deleted user)

Resolved in code review.

Resolved in code review.

Thursday 05 Oct 2023
2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-16466 Allow alarm ID 282/281 to only occur in pre-treatment or treatment modes.

Options
    • -1
    • +1
    ./ModeDrain.c
2:09 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-16466 Allow alarm ID 282 to only occur in pre-treatment or treatment modes.

Options
    • -4
    • +10
    ./ModeDrain.c
1:39 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-16466 Allow alarm ID 282 to only occur in pre-treatment or treatment modes.

Options
    • -2
    • +10
    ./ModeDrain.c
Tuesday 03 Oct 2023
2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

11:46 am

Vinayakam Mani

DEN-16395 fix merge issues

Options
    • -2
    • +2
    ./ModeDrain.c
  2. … 4 more files in changeset.
8:52 am

Dara Navaei

DEN-16446 updated the chemical disinfect flush for VectorCAST

Options
    • -2
    • +5
    ./ModeChemicalDisinfectFlush.c
Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:06 pm

Dara Navaei

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Options
    • -7
    • +9
    ./ModeFill.c
    • -3
    • +2
    ./OperationModes.c
  3. … 1 more file in changeset.
1:05 pm

Dara Navaei

1:03 pm

Dara Navaei and jtaylor  (deleted user)

1:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeDrain.c
    • -2
    • +2
    ./ModeFill.c
    • -2
    • +2
    ./ModeGenIdle.c
    • -2
    • +2
    ./OperationModes.c
  5. … 9 more files in changeset.
12:33 pm

Sean Nash

Merge branch 'DEN-15791-dg-software-design-description' into develop

Options
    • -1
    • +1
    ./ModeDrain.c
    • -5
    • +7
    ./ModeFill.c
    • -2
    • +2
    ./ModeGenIdle.c
    • -1
    • +0
    ./OperationModes.c
  5. … 5 more files in changeset.
11:41 am

Sean Nash

Merged staging to DEN-15791.

Options
    • -6
    • +8
    ./ModeDrain.c
    • -67
    • +84
    ./ModeFill.c
    • -10
    • +2
    ./ModeGenIdle.c
    • -1
    • +16
    ./OperationModes.c
  5. … 4 more files in changeset.
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
11:18 am

Dara Navaei

DEN-16446 updated the code and VectorCAST test cases

Options
    • -0
    • +3
    ./OperationModes.c
  2. … 1 more file in changeset.
8:56 am

Dara Navaei

Done

Done

8:56 am

Dara Navaei

DEN-16446 addressed the code review comment

Options
    • -1
    • +4
    ./ModeHeatDisinfect.c
8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

3:32 pm

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +3
    ./ModeHeatDisinfect.c
1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:57 am

Dara Navaei

DEN-16446 updated the code and VectorCAST test cases

Options
    • -1
    • +5
    ./ModeFill.c
8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Monday 25 Sep 2023
2:55 pm

Dara Navaei

DEN-16446 updated the code based on the VectorCAST tests

Options
    • -7
    • +7
    ./ModeChemicalDisinfect.c