dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Feb 2024
8:33 am

Dara Navaei

CD1 is used to check the difference between CD1 and CD2. CD1 is not used to check the reading of acid.

CD1 is used to check the difference between CD1 and CD2. CD1 is not used to check the reading of acid.

8:27 am

Dara Navaei

Will address in DEN-16693.

Will address in DEN-16693.

Tuesday 27 Feb 2024
3:55 pm

Sean Nash

All of these for loops are not following our coding standards. Should have bracketed scope even if single line of code in loop.

All of these for loops are not following our coding standards. Should have bracketed scope even if single line of code in loop.

3:54 pm

Sean Nash

Does this mean we aren't checking the CD1 sensor at all?

Does this mean we aren't checking the CD1 sensor at all?

Thursday 22 Feb 2024
11:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Dara Navaei

Yes this is still used in the deliver state. I changed the names in the #defines

Yes this is still used in the deliver state. I changed the names in the #defines

10:44 am

Sean Nash

Is this 5% definition still used? I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

Is this 5% definition still used?
I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

Wednesday 21 Feb 2024
3:30 pm

Vinayakam Mani

10:33 am

Dara Navaei

10:22 am

Vinayakam Mani and Sean Nash

9:33 am

Dara Navaei

DG-DEN-16666_Log Passing Results OF Self Test 2
DG-DEN-16666_Log Passing Results OF Self Test 2
Friday 16 Feb 2024
10:59 am

Dara Navaei

10:59 am

Dara Navaei and Sean Nash

10:58 am

Dara Navaei

10:57 am

Dara Navaei

Thursday 15 Feb 2024
1:03 pm

Dara Navaei

DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16674_Td2 Calibration Feature
12:52 pm

Sean Nash

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

Question was in relation to DG gen idle sub-state, not HD mode.

Question was in relation to DG gen idle sub-state, not HD mode.

9:53 am

dcox  (deleted user)

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Tre...

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

9:28 am

Sean Nash

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen id...

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).

Wednesday 14 Feb 2024
2:37 pm

Vinayakam Mani

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:15 pm

dcox  (deleted user)

Updated.

Updated.

Friday 09 Feb 2024
1:40 pm

Dara Navaei

9:43 am

Vinayakam Mani

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

9:36 am

Vinayakam Mani

Thursday 08 Feb 2024
1:48 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:43 pm

Sean Nash

12:31 pm

Dara Navaei

DG-DEN-16666_Log Passing Results OF Self Test TO UI Log
DG-DEN-16666_Log Passing Results OF Self Test TO UI Log
12:08 pm

dcox  (deleted user)

Updated.

Updated.