dgfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Mar 2024
2:47 pm

Dara Navaei

DEN-16682 updated the comments

Options
    • -2
    • +2
    ./ModeFill.c
  2. … 1 more file in changeset.
1:32 pm

Dara Navaei

DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities in the non-volaitle memory. Updated the VectorCAST test cases

Options
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +0
    ./ModeGenIdle.c
Tuesday 05 Mar 2024
3:41 pm

Dara Navaei

DEN-16682 removed CD1 check in the fill mode

Options
    • -16
    • +3
    ./ModeFill.c
8:14 am

Dara Navaei

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

Options
    • -2
    • +3
    ./ModeFill.c
  2. … 3 more files in changeset.
Saturday 02 Mar 2024
6:38 pm

Dara Navaei

3:58 pm

Dara Navaei

DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

Options
    • -1
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.
Friday 01 Mar 2024
5:24 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +1
    ./ModeFill.h
    • -2
    • +2
    ./ModeGenIdle.c
  4. … 7 more files in changeset.
4:52 pm

Dara Navaei

DEN-16682 changed the acid pumps speed in mode fill

Options
    • -1
    • +1
    ./ModeFill.c
4:31 pm

Dara Navaei

4:21 pm

Vinayakam Mani and Sean Nash

4:21 pm

Vinayakam Mani

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:16 pm

Dara Navaei

DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
3:50 pm

Dara Navaei

Done

Done

1:39 pm

Vinayakam Mani

Can we bring a parenthesis for better readability?

Can we bring a parenthesis for better readability?

10:54 am

Dara Navaei

9:27 am

Dara Navaei

DEN-16674 updated the code from staging

Options
    • -7
    • +94
    ./ModeFill.c
    • -0
    • +2
    ./ModeFill.h
    • -1
    • +1
    ./ModeGenIdle.c
  4. … 7 more files in changeset.
8:41 am

Dara Navaei

DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16674_Td2 Calibration Feature
Thursday 29 Feb 2024
3:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeFill.c
    • -1
    • +1
    ./ModeFill.h
  3. … 7 more files in changeset.
2:45 pm

Dara Navaei

1:45 pm

Sean Nash

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:04 pm

Dara Navaei

DEN-16674 addressed the code reivew comment

Options
    • -0
    • +1
    ./ModeFill.c
  2. … 1 more file in changeset.
1:04 pm

Dara Navaei

Done

Done

1:01 pm

Sean Nash

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

12:54 pm

Dara Navaei

No I will check the Dialin check in the function like the rest of the commands from Dialin.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

12:50 pm

Sean Nash

I don't see change. Did you push?

I don't see change. Did you push?

12:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.