Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-16682 updated the comments

  1. … 1 more file in changeset.
DEN-16682 changed the fill mode to get the target conductivity values from the bicarb values of the fill conductivities in the non-volaitle memory. Updated the VectorCAST test cases

DEN-16682 removed CD1 check in the fill mode

DEN-16682 upaded the drivers to get the calibration values once the signal is emitted. DENBUG-199 updated the drain pump driver

  1. … 3 more files in changeset.
DEN-16682 added the alarm for the fill acid/bicarb target conductivities in the DG calibration record

  1. … 1 more file in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
DEN-16682 changed the acid pumps speed in mode fill

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16682_Use Cd2 Values For Acid Check
DG-DEN-16682_Use Cd2 Values For Acid Check
Done

Done

Can we bring a parenthesis for better readability?

Can we bring a parenthesis for better readability?

DEN-16674 updated the code from staging

  1. … 7 more files in changeset.
DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16674_Td2 Calibration Feature
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-16674 addressed the code reivew comment

  1. … 1 more file in changeset.
Done

Done

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

I don't see change. Did you push?

I don't see change. Did you push?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.