Activity dgfirmware/firmware/App/Modes

Tree
Accordion

Stats

Commits this week: 4

Total Committers:	15
Last Commit:	10 Jun
Commits this week:	4

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 05 Jun 2025

4:14 pm

Dara Navaei

More
d72a480
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 addressed the code review comment

- -1
- +1
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

10:01 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

hd mode should be >= standby mode. You have it backward.

hd mode should be >= standby mode. You have it backward.

10:00 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:33 am

Dara Navaei

More
b28aa87
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 addressed the code review comments

- -1
- +3
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -2
- +2
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

9:20 am

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done.

Done.

Wednesday 04 Jun 2025

2:23 pm

Dara Navaei

More
68f28bf
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added code to request the DG institutional values in mode standby until they are received

- -12
- +26
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
… 1 more file in changeset.

1:19 pm

Dara Navaei

More
6727e2e
changed 2 files
develop

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

- -2
- +0
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
… 1 more file in changeset.

1:17 pm

Dara Navaei

More
80a1b60
changed 4 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added code to keep requesting DG institutional values once start DG has been sent until the values are received

- -2
- +0
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
- -7
- +28
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -0
- +2
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
… 1 more file in changeset.

Thursday 29 May 2025

3:41 pm

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

Should we have before and after values in event data?

Should we have before and after values in event data?

Wednesday 28 May 2025

11:08 am

Dara Navaei

More
610d258
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added the request command to get the DG institutional record from HD upon starting the DG

- -0
- +3
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

9:45 am

Dara Navaei

More
14b5aa8
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added an RO rejection ratio event

- -0
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Tuesday 27 May 2025

5:33 pm

Dara Navaei

More
df09fff
changed 3 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 changed the max RO rejection ratio to min RO rejection ratio in percent and updated the mode fill calculations to check the RR

- -9
- +12
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -1
- +1
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
… 1 more file in changeset.

9:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Removed. UI is updated too.

Removed. UI is updated too.

9:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 23 May 2025

3:54 pm

Dara Navaei

More
41dc41d
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-320 removed the acid and bicarb used volumes in mode fill broadcast

- -2
- +0
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -2
- +0
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h

10:03 am

Dara Navaei

More
255e101
changed 5 files
develop

Merged DENBUG-318

- -0
- +2
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
… 4 more files in changeset.

10:01 am

Dara Navaei

More
3c4db4b
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added a new event for min inlet water conductivity alarm from HD institutional record

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

9:49 am

Dara Navaei

More
caa8c39
changed 7 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 updated the code to receive all the DG institutional record items. Added code to use the min inlet water conductivity alarm from the institutional record

- -0
- +2
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
- -1
- +0
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
… 5 more files in changeset.

Thursday 22 May 2025

4:27 pm

Dara Navaei

More
27792ea
changed 6 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-319 added code to receive a command from dialing to enable the mode fill chemicals test

- -0
- +21
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -0
- +2
./ModeFill.h
- History
- Source
- Diff
./ModeFill.h
- -2
- +2
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c
… 3 more files in changeset.

1:35 pm

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done

Done

12:54 pm

Sean Nash

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Wednesday 21 May 2025

5:03 pm

Dara Navaei

More
3bd1f94
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-319 added code to skip the acid and bicarb check in mode fill if it is not the first fill

- -6
- +12
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

3:28 pm

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done

Done

2:54 pm

Dara Navaei

More
7acc14a
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 changed the location of requesting RO rejection ratio upon starting DG

- -1
- +0
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
- -0
- +1
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

9:17 am

Dara Navaei

More
c96d184
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-320 addressed a code review comment

- -1
- +1
./ModeGenIdle.c
- History
- Source
- Diff
./ModeGenIdle.c

9:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:59 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

I don't see the flag being set in this function.

I don't see the flag being set in this function.

8:55 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-11 04:03 -0700