SystemComm.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-14689-messaging-bugs' into develop

  1. … 6 more files in changeset.
DEN-14689: sync msg_ids with msgdefs.h

  1. … 3 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Merge branch 'DEN-14689-messaging-bugs' into develop

  1. … 2 more files in changeset.
Merge branch 'staging' into DEN-14689-messaging-bugs

  1. … 1 more file in changeset.
DEN-14689: message naming synchronization.

  1. … 6 more files in changeset.
I don't see DG changes using new ENUM names.

I don't see DG changes using new ENUM names.

What is this setting and why did it change?

What is this setting and why did it change?

Comment alignment (3x 147, 151, 157)

Comment alignment (3x 147, 151, 157)

DEN-14763 work in progress. Finished coding heat disinfect active cool and removed DG CPLD send command since it is broadcasting all the time

  1. … 7 more files in changeset.
//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

//* ?

Add function header.

Add function header.

Add function headers.

Add function headers.

Add tempBelowTargetStartTimeMS and rsrvrsStatus.

Add tempBelowTargetStartTimeMS and rsrvrsStatus.

Add function headers.

Add function headers.

Add comments and alignment.

Add comments and alignment.