dgfirmware / firmware / App / Services

SystemComm.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

2:54 pm

Michael Garthwaite

1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

12:26 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash

11:27 am

Michael Garthwaite

11:24 am

wbracken  (deleted user) and Sean Nash

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

jtaylor  (deleted user)

Suggest aligning comments in the block above

Suggest aligning comments in the block above

Friday 18 Aug 2023
12:35 pm

Michael Garthwaite

Removed #define. Thanks!

Removed #define. Thanks!

11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:36 am

Sean Nash

Add blank line between functions.

Add blank line between functions.

10:35 am

Sean Nash

Add blank line between banner comment and prototype.

Add blank line between banner comment and prototype.

10:13 am

Sean Nash

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

9:58 am

Sean Nash

I don't see where this #define is ever used. Remove if not needed.

I don't see where this #define is ever used. Remove if not needed.

Thursday 17 Aug 2023
8:04 pm

Dara Navaei

DG-DIAL-280_Reservoir Broadcast Override
DG-DIAL-280_Reservoir Broadcast Override
6:04 pm

Dara Navaei

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
2:04 pm

Dara Navaei

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
10:55 am

Sean Nash

Wednesday 16 Aug 2023
10:28 am

Michael Garthwaite

10:25 am

jtaylor  (deleted user)

9:10 am

Michael Garthwaite

8:59 am

Sean Nash , jtaylor  (deleted user) and Dara Navaei

8:33 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 15 Aug 2023
6:39 pm

wbracken  (deleted user)

4:38 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:21 pm

Dara Navaei