SystemComm.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
required changes are done.

required changes are done.

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Suggest aligning comments in the block above

Suggest aligning comments in the block above

Removed #define. Thanks!

Removed #define. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Add blank line between functions.

Add blank line between functions.

Add blank line between banner comment and prototype.

Add blank line between banner comment and prototype.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

I don't see where this #define is ever used. Remove if not needed.

I don't see where this #define is ever used. Remove if not needed.

DG-DIAL-280_Reservoir Broadcast Override
DG-DIAL-280_Reservoir Broadcast Override
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!