SystemCommMessages.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9480 worked on the heaters control

  1. … 7 more files in changeset.
Merge branch 'DEN-7802-dg_dev-dialysate-generation' into staging

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Nice catch. Fixed.

Nice catch. Fixed.

The max part of these do not look right (backward).

The max part of these do not look right (backward).

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

  1. … 4 more files in changeset.
DEN-9480 worked on developing new heaters control

  1. … 10 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

DEN-7802: Addressed code review comments

  1. … 8 more files in changeset.
Done.

Done.

Done.

Done.

Done.

Done.

I would prefer we return a TRUE or FALSE explicitly (like function below).

I would prefer we return a TRUE or FALSE explicitly (like function below).

Removed.

Removed.

Start comments w/ capital letter.

Start comments w/ capital letter.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.

I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.