dgfirmware / firmware / App / Services

SystemCommMessages.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Oct 2023
9:20 am

Dara Navaei

Done

Done

Sunday 08 Oct 2023
5:55 pm

wbracken  (deleted user)

sizeof should be first in if

sizeof should be first in if

Friday 06 Oct 2023
10:19 am

wbracken  (deleted user)

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken  (deleted user)

Resolved in code review.

Resolved in code review.

Tuesday 03 Oct 2023
2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:05 pm

Dara Navaei

1:03 pm

Dara Navaei and jtaylor  (deleted user)

Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Tuesday 19 Sep 2023
2:07 pm

Dara Navaei

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
Thursday 14 Sep 2023
9:49 am

Dara Navaei

9:00 am

Dara Navaei and wbracken  (deleted user)

Tuesday 12 Sep 2023
10:12 am

jtaylor  (deleted user)

Monday 11 Sep 2023
12:05 pm

Dara Navaei

DG-DIAL-283_NO Moving Average Commands Conductivity
DG-DIAL-283_NO Moving Average Commands Conductivity
Friday 01 Sep 2023
4:58 pm

Vinayakam Mani

Wednesday 30 Aug 2023
2:26 pm

Michael Garthwaite

12:28 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Tuesday 29 Aug 2023
5:01 pm

Dara Navaei

2:07 pm

Dara Navaei

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
12:32 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:30 am

Dara Navaei

Please add _MS to be consistent with the reset of times which are all in milliseconds.

Please add _MS to be consistent with the reset of times which are all in milliseconds.