Activity dgfirmware/firmware/App/Services

10:24 am

Dara Navaei

More
3ca2e68
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-9054-1 DG-DEN-8886-1 DG-DEN-7802-1

DEN-9054 added the message argument to the service info handler

- -1
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -1
- +1
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

9:50 am

Dara Navaei

More
7e138e7
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-9054-1

DEN-9054 removed the message argument in the system and service record handlers

- -2
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -4
- +2
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -2
- +2
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

9:48 am

Dara Navaei

More
Re: DG-DEN-9054-1
replied to qnguyen (deleted user)

Fixed the maxBufferLength variable.

9:43 am

Dara Navaei

More
Re: DG-DEN-9054-1
replied to qnguyen (deleted user)

Done.

9:42 am

Dara Navaei

More
Re: DG-DEN-9054-1
replied to qnguyen (deleted user)

Done.

9:34 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
commented on review

Unused parameter.

9:33 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
commented on review

Looks like the parameter is not being used.

9:28 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
commented on review

maxBufferLength variable is not needed in this case and the comment is not matched the code. Suggest revert this change to line 2139.

maxBufferLength variable is not needed in this case and the comment is not matched the code.
Suggest revert this change to line 2139.

10:33 am

Sean Nash

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

4:44 pm

Dara Navaei

More
67021fb
changed 21 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-7802-1 DG-DEN-9054-1 DG-DEN-8886-1

DEN-9054 merged stagin

- -96
- +3
./AlarmMgmt.h
- History
- Source
- Diff
./AlarmMgmt.h
- -0
- +135
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -1
- +13
./FPGA.c
- History
- Source
- Diff
./FPGA.c
- -0
- +2
./FPGA.h
- History
- Source
- Diff
./FPGA.h
- -3
- +7
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
- -7
- +8
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +36
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -6
- +6
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
- -1
- +1
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 12 more files in changeset.

3:50 pm

Dara Navaei

More
b7c3052
changed 6 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 212 more DG-DEN-9054-1

DEN-9054 implemented debouncing for the DG switches and implemented FPGA GPIO power

- -3
- +23
./FPGA.c
- History
- Source
- Diff
./FPGA.c
… 5 more files in changeset.

9:03 am

Dara Navaei

More
Re: DG-DEN-9054-1
replied to Sean Nash

The signal is debounced for 50ms. I added a debounce for a longer time.

9:35 pm

Dara Navaei

More
Re: DG-DEN-9054-1
replied to Sean Nash

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

5:56 pm

Quang Nguyen <qnguyen@diality.com>

More
c0e9f4a
changed 2 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

- -10
- +10
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 1 more file in changeset.

5:55 pm

Sean Nash

More
325ad79
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-8886-1

DEN-8886: Disable WD POST recovery check until issue can be resolved with EE team.

- -7
- +7
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c

5:48 pm

Sean Nash

More
e71edaa
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-8886-1

DEN-8886: Increased WD POST recovery time to allow 24V more time to come back up.

- -1
- +1
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c

4:48 pm

Sean Nash

More
386dd5b
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-8886-1

DEN-8886: Fix watchdog test to verify the correct 24V channel.

- -2
- +2
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c

3:20 pm

Quang Nguyen <qnguyen@diality.com>

More
a79db34
changed 19 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more DG-DEN-14902-1 DG-DEN-15336-1

Merge branch 'DEN-9054-dg-hd_dev-dg-hd-switches' into develop

- -6
- +5
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -0
- +50
./FPGA.c
- History
- Source
- Diff
./FPGA.c
- -1
- +5
./FPGA.h
- History
- Source
- Diff
./FPGA.h
- -0
- +13
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -15
- +156
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -1
- +18
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
- -2
- +2
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 12 more files in changeset.

2:10 pm

Quang Nguyen <qnguyen@diality.com>

More
195f895
changed 8 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more DG-DEN-14902-1 DG-DEN-15336-1

Merge branch 'DEN-8886-hd_dg_dev-self-tests-2-of-2' into develop

- -64
- +4
./Interrupts.c
- History
- Source
- Diff
./Interrupts.c
- -21
- +4
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +34
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
- -10
- +39
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 3 more files in changeset.

2:07 pm

Quang Nguyen <qnguyen@diality.com>

More
9779d54
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 210 more DG-DEN-7802-1

DEN-7802: Changed according to lab test

- -1
- +1
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
… 1 more file in changeset.

1:48 pm

Dara Navaei

More
Re: DG-DEN-9054-1
replied to Sean Nash

Done.

10:55 am

Sean Nash

More
Re: DG-DEN-9054-1
commented on review

Need function header.

10:54 am

Sean Nash

More
Re: DG-DEN-9054-1
commented on review

Should we debounce switches before changing states? Check with Noe to see if FPGA is already debouncing these signals.

10:38 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen (deleted user)

More
Re: DG-DEN-9054-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

Services

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

Dara Navaei

Sean Nash

Sean Nash

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)