Activity dgfirmware/firmware/App/Services

12:10 pm

Michael Garthwaite

More
01875de
changed 3 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12121-sw_dev-sprint-65-michael-garthwaite and 202 more DG-DEN-12121-1

DEN-12121: Updated per peer review.

- -5
- +8
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -2
- +3
./SystemComm.h
- History
- Source
- Diff
./SystemComm.h
- -4
- +4
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

8:53 am

Sean Nash

We need to decide what DG should do if HD comm times out. Alarm may not make sense since HD apparently not connected to receive/display alarm. Appropriate action may be mode specific.

We need to decide what DG should do if HD comm times out.
Alarm may not make sense since HD apparently not connected to receive/display alarm.
Appropriate action may be mode specific.

5:22 pm

Dara Navaei

More
35c0719
changed 10 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Merged DEN-12224 and resolved the conflicts

- -2
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -14
- +8
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -2
- +2
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 7 more files in changeset.

5:02 pm

Dara Navaei

More
8ea2ea3
changed 5 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224, DEN-12232 added a command to be able to set the fans RPM alarm start time offset

- -2
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -16
- +10
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -2
- +2
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 2 more files in changeset.

10:09 am

Michael Garthwaite

Update. Function will be reworked to have proper override control instead of always flipping to True.

5:51 pm

Dara Navaei

More
e0cdf49
changed 25 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 added F to the defines that are floating numbers

- -3
- +3
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
- -1
- +1
./Reservoirs.h
- History
- Source
- Diff
./Reservoirs.h
- -2
- +2
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 22 more files in changeset.

4:18 pm

Dara Navaei

More
51e60f3
changed 15 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more DG-DEN-14902-1 DG-DEN-15336-1

Merged DEN-12224 and resolved the conflicts

- -1
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -1
- +1
./SystemComm.h
- History
- Source
- Diff
./SystemComm.h
- -8
- +11
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -1
- +1
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 11 more files in changeset.

2:55 pm

Michael Garthwaite

More
Re: DG-DEN-12121-1
replied to Sean Nash

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

2:47 pm

Michael Garthwaite

Looks like it was commented out in this commit in August. http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c ...

Looks like it was commented out in this commit in August.

http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c

Should I uncomment it?

11:23 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Uncommented and recompiled without errors

8:53 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

We do not have doxygen comments for the function declarations.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

8:50 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

8:45 pm