dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Mar 2022
1:11 pm

Michael Garthwaite

DEN-12121: Fixed compilation error

Options
    • -1
    • +1
    ./SystemComm.h
12:21 pm

Michael Garthwaite

Reworked function to give API control of HD communication status.

Reworked function to give API control of HD communication status.

12:20 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65-michael-garthwaite' into develop

Options
    • -5
    • +8
    ./SystemComm.c
    • -4
    • +4
    ./SystemCommMessages.c
12:18 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:18 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:18 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:18 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:17 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:14 pm

Michael Garthwaite

Merge branch 'staging' into DEN-12121-sw_dev-sprint-65-michael-garthwaite

Options
    • -3
    • +20
    ./SystemComm.c
    • -9
    • +9
    ./SystemComm.h
    • -22
    • +198
    ./SystemCommMessages.c
    • -1
    • +16
    ./SystemCommMessages.h
  5. … 1 more file in changeset.
12:10 pm

Michael Garthwaite

DEN-12121: Updated per peer review.

Options
    • -5
    • +8
    ./SystemComm.c
    • -2
    • +3
    ./SystemComm.h
    • -4
    • +4
    ./SystemCommMessages.c
8:53 am

Sean Nash

We need to decide what DG should do if HD comm times out. Alarm may not make sense since HD apparently not connected to receive/display alarm. Appropriate action may be mode specific.

We need to decide what DG should do if HD comm times out.
Alarm may not make sense since HD apparently not connected to receive/display alarm.
Appropriate action may be mode specific.

Tuesday 08 Mar 2022
5:22 pm

Dara Navaei

Merged DEN-12224 and resolved the conflicts

Options
    • -2
    • +2
    ./SystemComm.c
    • -14
    • +8
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  4. … 7 more files in changeset.
5:02 pm

Dara Navaei

DEN-12224, DEN-12232 added a command to be able to set the fans RPM alarm start time offset

Options
    • -2
    • +2
    ./SystemComm.c
    • -16
    • +10
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  4. … 2 more files in changeset.
10:09 am

Michael Garthwaite

Update. Function will be reworked to have proper override control instead of always flipping to True.

Update. Function will be reworked to have proper override control instead of always flipping to True.

Monday 07 Mar 2022
5:51 pm

Dara Navaei

DEN-12224 added F to the defines that are floating numbers

Options
    • -3
    • +3
    ./Reservoirs.c
    • -1
    • +1
    ./Reservoirs.h
    • -2
    • +2
    ./WatchdogMgmt.c
  4. … 22 more files in changeset.
4:18 pm

Dara Navaei

Merged DEN-12224 and resolved the conflicts

Options
    • -1
    • +1
    ./SystemComm.c
    • -1
    • +1
    ./SystemComm.h
    • -8
    • +11
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
  5. … 11 more files in changeset.
2:55 pm

Michael Garthwaite

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

2:47 pm

Michael Garthwaite

Looks like it was commented out in this commit in August. http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c ...

Looks like it was commented out in this commit in August.

http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c

Should I uncomment it?

11:23 am

hnguyen  (deleted user)

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen  (deleted user)

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen  (deleted user)

Uncommented and recompiled without errors

Uncommented and recompiled without errors

Sunday 06 Mar 2022
8:53 pm

Dara Navaei

We do not have doxygen comments for the function declarations.

We do not have doxygen comments for the function declarations.

8:52 pm

Dara Navaei

Add a space.

Add a space.

8:52 pm

Dara Navaei

Add a space.

Add a space.

8:50 pm

Dara Navaei

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

8:45 pm

Dara Navaei

Why is this commented out?

Why is this commented out?

Friday 04 Mar 2022
2:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:36 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.