dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jan 2023
3:33 pm

Sean Nash

Fixed merge conflicts.

Options
    • -0
    • +2
    ./AlarmMgmt.c
    • -1
    • +2
    ./AlarmMgmtSWFaults.h
    • -3
    • +3
    ./PIControllers.c
    • -2
    • +6
    ./SystemComm.c
    • -4
    • +37
    ./SystemCommMessages.c
    • -1
    • +4
    ./SystemCommMessages.h
  7. … 17 more files in changeset.
8:30 am

Sean Nash

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

8:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 09 Jan 2023
3:04 pm

Dara Navaei

DEN-14497 updated the drain pump flow control algorithm. Fixed the inlet water pressure, temperature, conductivity alarm recovery in treatment modes. Updated chemical disinfect flush mode

Options
    • -0
    • +2
    ./AlarmMgmt.c
    • -3
    • +3
    ./PIControllers.c
  3. … 9 more files in changeset.
11:37 am

wbracken  (deleted user)

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

11:07 am

wbracken  (deleted user)

Removed.

Removed.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

Friday 06 Jan 2023
4:02 pm

Sean Nash

Why change this to U08?

Why change this to U08?

10:58 am

wbracken  (deleted user)

Add to header and alignment.

Add to header and alignment.

Thursday 05 Jan 2023
11:38 am

Sean Nash

Use get function for override.

Use get function for override.

9:56 am

Sean Nash

Fixed merge conflicts.

Options
    • -1
    • +1
    ./AlarmMgmtSWFaults.h
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +3
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
  5. … 10 more files in changeset.
Wednesday 04 Jan 2023
3:00 pm

Dara Navaei

DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
12:01 pm

wbracken  (deleted user)

Assume this is for testing?

Assume this is for testing?

Tuesday 03 Jan 2023
10:10 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./AlarmMgmt.c
    • -1
    • +1
    ./AlarmMgmt.h
    • -1
    • +1
    ./AlarmMgmtSWFaults.h
    • -1
    • +1
    ./CommBuffers.c
    • -1
    • +1
    ./CommBuffers.h
    • -1
    • +1
    ./FPGA.c
    • -1
    • +1
    ./FPGA.h
    • -1
    • +1
    ./Interrupts.c
    • -1
    • +1
    ./Interrupts.h
    • -1
    • +1
    ./MsgQueues.c
    • -1
    • +1
    ./MsgQueues.h
    • -1
    • +1
    ./PIControllers.c
    • -1
    • +1
    ./PIControllers.h
    • -1
    • +1
    ./Reservoirs.c
    • -1
    • +1
    ./Reservoirs.h
  16. … 84 more files in changeset.
10:10 am

Dara Navaei

8:50 am

Sean Nash

8:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 02 Jan 2023
5:14 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

5:03 pm

Dara Navaei

DEN-14101 merged staging

Options
    • -5
    • +57
    ./SystemComm.c
    • -75
    • +531
    ./SystemCommMessages.c
  3. … 3 more files in changeset.
4:46 pm

Dara Navaei

Done

Done

4:45 pm

Dara Navaei

Done.

Done.

4:44 pm

Dara Navaei

Done.

Done.

4:32 pm

Dara Navaei

Done.

Done.

Sunday 01 Jan 2023
11:11 pm

wbracken  (deleted user)

Should be removed?

Should be removed?

11:07 pm

wbracken  (deleted user)

The description seems to be missing a few words.

The description seems to be missing a few words.

11:05 pm

wbracken  (deleted user)

Add heaterStatus to header.

Add heaterStatus to header.

10:57 pm

wbracken  (deleted user)

Header needs to be updated.

Header needs to be updated.

10:56 pm

wbracken  (deleted user)

Alignment.

Alignment.