Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed merge conflicts.

  1. … 17 more files in changeset.
Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14497 updated the drain pump flow control algorithm. Fixed the inlet water pressure, temperature, conductivity alarm recovery in treatment modes. Updated chemical disinfect flush mode

  1. … 9 more files in changeset.
Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

Removed.

Removed.

Remove blank line.

Remove blank line.

Why change this to U08?

Why change this to U08?

Add to header and alignment.

Add to header and alignment.

Use get function for override.

Use get function for override.

Fixed merge conflicts.

  1. … 10 more files in changeset.
DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
Assume this is for testing?

Assume this is for testing?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 84 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

DEN-14101 merged staging

  1. … 3 more files in changeset.
Done

Done

Done.

Done.

Done.

Done.

Done.

Done.

Should be removed?

Should be removed?

The description seems to be missing a few words.

The description seems to be missing a few words.

Add heaterStatus to header.

Add heaterStatus to header.

Header needs to be updated.

Header needs to be updated.

Alignment.

Alignment.